Use DiscardableMemoryManager on Android.

base/memory/discardable_memory_android.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/discardable_memory.h"
 
 #include "base/android/sys_utils.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/discardable_memory_allocator_android.h"
+#include "base/memory/discardable_memory_ashmem.h"
 #include "base/memory/discardable_memory_emulated.h"
 #include "base/memory/discardable_memory_malloc.h"
 
 namespace base {
 namespace {
 
 const char kAshmemAllocatorName[] = "DiscardableMemoryAllocator";
 
-struct DiscardableMemoryAllocatorWrapper {
-  DiscardableMemoryAllocatorWrapper()
+// When ashmem is used, have the DiscardableMemoryManager trigger userspace
+// eviction when address space usage gets too high, e.g. 512 MBytes on 32 bit
+// systems vs 16 GBytes on 64 bits.
+const size_t kAshmemMaxAddressSpaceUsage =
+    ((sizeof(void*) == 4) ? 512 : 16 * 1024) * 1024 * 1024;

[reveman, 2014/04/26 00:13:37]

I would prefer if used the same constant on 64bit to start with. 512MB is fine
if that's the highest you think we should use on 32bit.

[Philippe, 2014/04/28 12:23:14]

Done.

+
+// Holds the state used for ashmem allocations.
+struct AshmemGlobalContext {
+  AshmemGlobalContext()
       : allocator(kAshmemAllocatorName,
                   GetOptimalAshmemRegionSizeForAllocator()) {
+    manager.SetMemoryLimit(kAshmemMaxAddressSpaceUsage);
   }
 
   internal::DiscardableMemoryAllocator allocator;
+  internal::DiscardableMemoryManager manager;
 
  private:
   // Returns 64 MBytes for a 512 MBytes device, 128 MBytes for 1024 MBytes...
   static size_t GetOptimalAshmemRegionSizeForAllocator() {
     // Note that this may do some I/O (without hitting the disk though) so it
     // should not be called on the critical path.
     return base::android::SysUtils::AmountOfPhysicalMemoryKB() * 1024 / 8;
   }
 };
 
-LazyInstance<DiscardableMemoryAllocatorWrapper>::Leaky g_context =
-    LAZY_INSTANCE_INITIALIZER;
+LazyInstance<AshmemGlobalContext>::Leaky g_context = LAZY_INSTANCE_INITIALIZER;
 
 }  // namespace
 
 // static
 void DiscardableMemory::RegisterMemoryPressureListeners() {
   internal::DiscardableMemoryEmulated::RegisterMemoryPressureListeners();
 }
 
 // static
 void DiscardableMemory::UnregisterMemoryPressureListeners() {
   internal::DiscardableMemoryEmulated::UnregisterMemoryPressureListeners();
 }
 
 // static
 void DiscardableMemory::GetSupportedTypes(
     std::vector<DiscardableMemoryType>* types) {
   const DiscardableMemoryType supported_types[] = {
     DISCARDABLE_MEMORY_TYPE_ANDROID,

[reveman, 2014/04/26 00:13:37]

Please rename this to DISCARDABLE_MEMORY_TYPE_ASHMEM as part of this patch.

[Philippe, 2014/04/28 12:23:14]

Sure.

     DISCARDABLE_MEMORY_TYPE_EMULATED,
     DISCARDABLE_MEMORY_TYPE_MALLOC
   };
   types->assign(supported_types, supported_types + arraysize(supported_types));
 }
 
 // static
 scoped_ptr<DiscardableMemory> DiscardableMemory::CreateLockedMemoryWithType(
     DiscardableMemoryType type, size_t size) {
   switch (type) {
     case DISCARDABLE_MEMORY_TYPE_NONE:
     case DISCARDABLE_MEMORY_TYPE_MAC:
       return scoped_ptr<DiscardableMemory>();
     case DISCARDABLE_MEMORY_TYPE_ANDROID: {
-      return g_context.Pointer()->allocator.Allocate(size);
+      AshmemGlobalContext* const global_context = g_context.Pointer();
+      scoped_ptr<internal::DiscardableMemoryAshmem> memory(
+          new internal::DiscardableMemoryAshmem(
+              size, &global_context->allocator, &global_context->manager));
+      if (!memory->Initialize())
+        return scoped_ptr<DiscardableMemory>();
+
+      return memory.PassAs<DiscardableMemory>();
     }
     case DISCARDABLE_MEMORY_TYPE_EMULATED: {
       scoped_ptr<internal::DiscardableMemoryEmulated> memory(
           new internal::DiscardableMemoryEmulated(size));
       if (!memory->Initialize())
         return scoped_ptr<DiscardableMemory>();
 
       return memory.PassAs<DiscardableMemory>();
     }
     case DISCARDABLE_MEMORY_TYPE_MALLOC: {
@@ skipping 14 matching lines @@
 bool DiscardableMemory::PurgeForTestingSupported() {
   return false;
 }
 
 // static
 void DiscardableMemory::PurgeForTesting() {
   NOTIMPLEMENTED();
 }
 
 }  // namespace base