Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1958593003: Allow compiling with enable_print_preview=false (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow compiling with enable_print_preview=false Earlier the warning shows an "unused variable" which is only used when enable_print_preview is true. So enclose the variable definition as well to avoid the compilation warning. BUG=609723 Committed: https://crrev.com/aefb7f695c0cfb750974c8662fe7db6f6da91693 Cr-Commit-Position: refs/heads/master@{#392247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Wei Li
for review, thanks
4 years, 7 months ago (2016-05-06 22:08:36 UTC) #3
jam
lgtm
4 years, 7 months ago (2016-05-06 23:50:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958593003/1
4 years, 7 months ago (2016-05-07 04:37:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 05:46:08 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 05:47:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aefb7f695c0cfb750974c8662fe7db6f6da91693
Cr-Commit-Position: refs/heads/master@{#392247}

Powered by Google App Engine
This is Rietveld 408576698