Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=haraken,rtoy
BUG=581660
Committed: https://crrev.com/5f4b6587aff0f53c1c90e38b7c26a7839784c4f9
Cr-Commit-Position: refs/heads/master@{#392110}

[sof, 2016-05-06 09:56:37]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2016-05-06 09:56:38]

please take a look.

[haraken, 2016-05-06 10:10:38]

haraken@chromium.org changed reviewers:
+ rtoy@chromium.org

[haraken, 2016-05-06 10:10:38]

LGTM but I want to have rtoy take another look.

[Raymond Toy, 2016-05-06 15:16:05]

lgtm.

Does this fix some issue with m_activeSourceNodes? Even if not, it's really nice
to have these things updated on only one thread since that's much easier to
reason about.

[hongchan, 2016-05-06 16:36:41]

hongchan@chromium.org changed reviewers:
+ hongchan@chromium.org

[hongchan, 2016-05-06 16:36:42]

This is a nice clean up. Thanks!

[sof, 2016-05-06 18:49:28]

On 2016/05/06 15:16:05, Raymond Toy wrote:
> lgtm.
> 
> Does this fix some issue with m_activeSourceNodes? Even if not, it's really
nice
> to have these things updated on only one thread since that's much easier to
> reason about.

It fixes (I hope) the lock inversion that issue 581660 shows up (which I
mentioned a bit via
https://bugs.chromium.org/p/chromium/issues/detail?id=590108#c7 ) ; I'll adjust
the BUG= line.

[sof, 2016-05-06 18:49:50]

Description was changed from

==========
Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=
BUG=590108
==========

to

==========
Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=haraken,rtoy
BUG=581660
==========

[sof, 2016-05-06 18:50:30]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-06 18:51:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958583002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958583002/1

[commit-bot: I haz the power, 2016-05-06 18:55:35]

Description was changed from

==========
Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=haraken,rtoy
BUG=581660
==========

to

==========
Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=haraken,rtoy
BUG=581660
==========

[commit-bot: I haz the power, 2016-05-06 18:55:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-06 18:57:03]

Description was changed from

==========
Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=haraken,rtoy
BUG=581660
==========

to

==========
Update AbstractAudioContext::m_activeSourceNodes on the main thread only.

Avoid mutating m_activeSourceNodes on the audio thread, leave the
main thread in control of that heap object.

R=haraken,rtoy
BUG=581660

Committed: https://crrev.com/5f4b6587aff0f53c1c90e38b7c26a7839784c4f9
Cr-Commit-Position: refs/heads/master@{#392110}
==========

[commit-bot: I haz the power, 2016-05-06 18:57:04]

Patchset 1 (id:??) landed as
https://crrev.com/5f4b6587aff0f53c1c90e38b7c26a7839784c4f9
Cr-Commit-Position: refs/heads/master@{#392110}