Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1958543002: requestAutocomplete: remove from web platform (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
CC:
android-webview-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, estade+watch_chromium.org, gavinp+loader_chromium.org, jam, Nate Chapin, jdonnelly+autofillwatch_chromium.org, kinuko+watch, loading-reviews_chromium.org, rwlbuis, rouslan+autofill_chromium.org, sof, tfarina, tyoshino+watch_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

requestAutocomplete: remove from web platform Intent to deprecate and remove thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/O9_XnDQh3Yk R=rouslan@chromium.org,tkent@chromium.org TBR=brettw@chromium.org TBR=dcheng@chromium.org for *_messages.h removal BUG=337587, 608824 Committed: https://crrev.com/7bf0571356aa1a09bb4dffd374fd793f406f38ef Cr-Commit-Position: refs/heads/master@{#392975}

Patch Set 1 : -GenericEventQueue #

Total comments: 2

Patch Set 2 : tkent review #

Patch Set 3 : Document-createEvent-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -574 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 3 chunks +0 lines, -6 lines 0 comments Download
D chrome/test/data/request_autocomplete/test_page.html View 1 chunk +0 lines, -17 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/constructors/autocomplete-error-event-constructor.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/constructors/autocomplete-error-event-constructor-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-creation.html View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/event-creation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/form-request-autocomplete.html View 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/form-request-autocomplete-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/constructor-length.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/script-tests/global-constructors.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 9 chunks +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 5 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/GlobalEventHandlers.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/GlobalEventHandlers.idl View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/events/AutocompleteErrorEvent.h View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/core/events/AutocompleteErrorEvent.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/core/events/AutocompleteErrorEventInit.idl View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTypeNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.h View 3 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 5 chunks +0 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormElement.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebAutofillClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFormElement.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (14 generated)
Dan Beam
4 years, 7 months ago (2016-05-06 17:13:31 UTC) #1
please use gerrit instead
lgtm, good cleanup!
4 years, 7 months ago (2016-05-06 17:22:43 UTC) #2
Dan Beam
tkent: cool with this given rbyers' response to the blink-dev thread?
4 years, 7 months ago (2016-05-10 05:39:28 UTC) #3
tkent
https://codereview.chromium.org/1958543002/diff/20001/third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html File third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html (left): https://codereview.chromium.org/1958543002/diff/20001/third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html#oldcode78 third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html:78: "AutocompleteErrorEvent", Please don't modify this file. This is an ...
4 years, 7 months ago (2016-05-10 05:44:48 UTC) #4
Dan Beam
https://codereview.chromium.org/1958543002/diff/20001/third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html File third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html (left): https://codereview.chromium.org/1958543002/diff/20001/third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html#oldcode78 third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent.html:78: "AutocompleteErrorEvent", On 2016/05/10 05:44:48, tkent wrote: > Please don't ...
4 years, 7 months ago (2016-05-10 17:08:17 UTC) #7
tkent
lgtm. Please update Document-createEvent-expected.txt.
4 years, 7 months ago (2016-05-10 23:55:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958543002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958543002/80001
4 years, 7 months ago (2016-05-11 01:23:38 UTC) #11
Dan Beam
On 2016/05/10 23:55:10, tkent wrote: > lgtm. > Please update Document-createEvent-expected.txt. Done.
4 years, 7 months ago (2016-05-11 01:23:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/180945)
4 years, 7 months ago (2016-05-11 01:33:35 UTC) #14
Dan Beam
+brettw@ for: android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt chrome/renderer/chrome_render_thread_observer.cc components/autofill/content/common/autofill_messages.h but mainly to please the almighty chromium_presubmit
4 years, 7 months ago (2016-05-11 01:38:17 UTC) #16
Dan Beam
TBR=dcheng@ for *_messages.h
4 years, 7 months ago (2016-05-11 17:22:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958543002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958543002/80001
4 years, 7 months ago (2016-05-11 17:30:38 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 7 months ago (2016-05-11 17:36:18 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:38:35 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7bf0571356aa1a09bb4dffd374fd793f406f38ef
Cr-Commit-Position: refs/heads/master@{#392975}

Powered by Google App Engine
This is Rietveld 408576698