Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py

Issue 1958463003: Mojom compiler: Eliminate duplicate representation of enum values in mojom_files.mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Responded to code reveiw comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py
diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py b/mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py
index dae6e6ad9b8c390b2288e5f1d837f3f76c00e166..3ca0cbaf1533ab09f3779393a503726a09b0d5a4 100644
--- a/mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py
+++ b/mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_types_mojom.py
@@ -150,9 +150,8 @@ class EnumValue(object):
DESCRIPTOR = {
'fields': [
_descriptor.SingleFieldGroup('decl_data', _descriptor.StructType(lambda: DeclarationData, nullable=True), 0, 0),
- _descriptor.SingleFieldGroup('enum_type_key', _descriptor.TYPE_STRING, 1, 0),
- _descriptor.SingleFieldGroup('initializer_value', _descriptor.UnionType(lambda: Value, nullable=True), 2, 0),
- _descriptor.SingleFieldGroup('int_value', _descriptor.TYPE_INT32, 3, 0),
+ _descriptor.SingleFieldGroup('initializer_value', _descriptor.UnionType(lambda: Value, nullable=True), 1, 0),
+ _descriptor.SingleFieldGroup('int_value', _descriptor.TYPE_INT32, 2, 0),
],
}
@@ -188,12 +187,22 @@ class MojomInterface(object):
],
}
-class UserValueReference(object):
+class ConstantReference(object):
__metaclass__ = _reflection.MojoStructType
DESCRIPTOR = {
'fields': [
_descriptor.SingleFieldGroup('identifier', _descriptor.TYPE_STRING, 0, 0),
- _descriptor.SingleFieldGroup('value_key', _descriptor.TYPE_NULLABLE_STRING, 1, 0),
+ _descriptor.SingleFieldGroup('constant_key', _descriptor.TYPE_STRING, 1, 0),
+ ],
+ }
+
+class EnumValueReference(object):
+ __metaclass__ = _reflection.MojoStructType
+ DESCRIPTOR = {
+ 'fields': [
+ _descriptor.SingleFieldGroup('identifier', _descriptor.TYPE_STRING, 0, 0),
+ _descriptor.SingleFieldGroup('enum_type_key', _descriptor.TYPE_STRING, 1, 0),
+ _descriptor.SingleFieldGroup('enum_value_index', _descriptor.TYPE_UINT32, 2, 0),
],
}
@@ -298,8 +307,9 @@ class Value(object):
DESCRIPTOR = {
'fields': [
_descriptor.SingleFieldGroup('literal_value', _descriptor.UnionType(lambda: LiteralValue), 0, 0),
- _descriptor.SingleFieldGroup('user_value_reference', _descriptor.StructType(lambda: UserValueReference), 1, 0),
- _descriptor.SingleFieldGroup('builtin_value', _descriptor.TYPE_INT32, 2, 0),
+ _descriptor.SingleFieldGroup('constant_reference', _descriptor.StructType(lambda: ConstantReference), 1, 0),
+ _descriptor.SingleFieldGroup('enum_value_reference', _descriptor.StructType(lambda: EnumValueReference), 2, 0),
+ _descriptor.SingleFieldGroup('builtin_value', _descriptor.TYPE_INT32, 3, 0),
],
}
@@ -322,12 +332,3 @@ class LiteralValue(object):
],
}
-class UserDefinedValue(object):
- __metaclass__ = _reflection.MojoUnionType
- DESCRIPTOR = {
- 'fields': [
- _descriptor.SingleFieldGroup('enum_value', _descriptor.StructType(lambda: EnumValue), 0, 0),
- _descriptor.SingleFieldGroup('declared_constant', _descriptor.StructType(lambda: DeclaredConstant), 1, 0),
- ],
- }
-

Powered by Google App Engine
This is Rietveld 408576698