mojo/dart/unittests/embedder_tests/bindings_generation_test.dart - Issue 1958463003: Mojom compiler: Eliminate duplicate representation of enum values in mojom_files.mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/unittests/embedder_tests/bindings_generation_test.dart

Issue 1958463003: Mojom compiler: Eliminate duplicate representation of enum values in mojom_files.mojom. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Responded to code reveiw comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart ('k') | mojo/go/tests/validation_type_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/unittests/embedder_tests/bindings_generation_test.dart

diff --git a/mojo/dart/unittests/embedder_tests/bindings_generation_test.dart b/mojo/dart/unittests/embedder_tests/bindings_generation_test.dart

index 80cd0d40e258295e740408205051751e55941f98..efc3bf71171950fd7abc24df1a6c289e675f5cb6 100644

--- a/mojo/dart/unittests/embedder_tests/bindings_generation_test.dart

+++ b/mojo/dart/unittests/embedder_tests/bindings_generation_test.dart

@@ -453,8 +453,7 @@ testValidateEnumType() {

Expect.isNotNull(ev.declData);

Expect.isNotNull(labelMap[ev.declData.shortName]);

- // Check that the enumTypeKey matches the enumID.

- Expect.equals(ev.enumTypeKey, enumID);

+ // Check that the enum value's intValue is as expected.

Expect.equals(ev.intValue, labelMap[ev.declData.shortName]);

});

}

« no previous file with comments | « mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart ('k') | mojo/go/tests/validation_type_test.go » ('j') | no next file with comments »