Update some secondary UI buttons to MD style.

Update some secondary UI buttons to MD style.

This has no effect when --secondary-ui-md is not passed.

BUG=571500
Committed: https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077
Cr-Commit-Position: refs/heads/master@{#393368}

[Evan Stade, 2016-05-09 22:34:43]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-05-09 22:34:50]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-05-09 22:35:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958453002/40001

[Evan Stade, 2016-05-10 17:06:37]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-05-10 17:07:01]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2016-05-10 17:07:01]

sky is ooo, sadrul could you take a look?

[commit-bot: I haz the power, 2016-05-10 17:07:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958453002/80001

[Evan Stade, 2016-05-10 17:07:24]

Description was changed from

==========
Update some secondary UI buttons to MD style.

BUG=571500
==========

to

==========
Update some secondary UI buttons to MD style.

This has no effect when --secondary-ui-md is not passed.

BUG=571500
==========

[commit-bot: I haz the power, 2016-05-10 18:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 18:35:37]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-05-11 04:56:59]

lgtm

https://codereview.chromium.org/1958453002/diff/80001/ui/views/controls/butto...
File ui/views/controls/button/label_button.h (right):

https://codereview.chromium.org/1958453002/diff/80001/ui/views/controls/butto...
ui/views/controls/button/label_button.h:115: bool explicitly_set_normal_color()
{
const

[Evan Stade, 2016-05-11 22:06:18]

https://codereview.chromium.org/1958453002/diff/80001/ui/views/controls/butto...
File ui/views/controls/button/label_button.h (right):

https://codereview.chromium.org/1958453002/diff/80001/ui/views/controls/butto...
ui/views/controls/button/label_button.h:115: bool explicitly_set_normal_color()
{
On 2016/05/11 04:56:59, sadrul wrote:
> const

Done.

[Evan Stade, 2016-05-11 22:06:27]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-11 22:06:28]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1958453002/#ps100001
(title: "const qualifier")

[commit-bot: I haz the power, 2016-05-11 22:06:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958453002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958453002/100001

[commit-bot: I haz the power, 2016-05-11 22:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 22:19:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-05-11 23:01:31]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[Evan Stade, 2016-05-11 23:01:32]

oops, sadrul only owns ui/views. +msw for c/b/ui/views

[msw, 2016-05-12 19:17:04]

lgtm with nits and a q.

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc:30: #include
"ui/views/controls/button/label_button.h"
nit: remove

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/certificate_selector.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/certificate_selector.cc:27: #include
"ui/views/controls/button/label_button.h"
nit: remove

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/download/download_item_view_md.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/download/download_item_view_md.cc:66: #include
"ui/views/controls/button/label_button.h"
nit: remove

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1290: if
(ui::MaterialDesignController::IsSecondaryUiMaterial()) {
q: why isn't this needed elsewhere?

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1292:
(*button)->SetEnabledTextColors(SK_ColorWHITE);
nit: use a theme color?

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
(right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:302: //
TODO(estade): this looks pretty crazy as an MD button because the button
nit: file a bug?

[Evan Stade, 2016-05-12 19:32:02]

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc:30: #include
"ui/views/controls/button/label_button.h"
On 2016/05/12 19:17:04, msw wrote:
> nit: remove

Done.

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/certificate_selector.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/certificate_selector.cc:27: #include
"ui/views/controls/button/label_button.h"
On 2016/05/12 19:17:04, msw wrote:
> nit: remove

Done.

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/download/download_item_view_md.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/download/download_item_view_md.cc:66: #include
"ui/views/controls/button/label_button.h"
On 2016/05/12 19:17:04, msw wrote:
> nit: remove

Done.

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1290: if
(ui::MaterialDesignController::IsSecondaryUiMaterial()) {
On 2016/05/12 19:17:04, msw wrote:
> q: why isn't this needed elsewhere?

because the factory in MdTextButton creates the appropriate kind of button based
on this switch. Here I have to do something slightly different for pre-md and
non-md, so I have to use the switch. That said, I've changed this code to also
use that factory because I want to get rid of public uses of SetStyle().

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1292:
(*button)->SetEnabledTextColors(SK_ColorWHITE);
On 2016/05/12 19:17:04, msw wrote:
> nit: use a theme color?

this isn't a surface that can be themed. This white matches the link text color
on L1305. Made them share a const.

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
(right):

https://codereview.chromium.org/1958453002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc:302: //
TODO(estade): this looks pretty crazy as an MD button because the button
On 2016/05/12 19:17:04, msw wrote:
> nit: file a bug?

added link to crbug.com/512442

[Evan Stade, 2016-05-12 19:32:09]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 19:32:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958453002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958453002/120001

[commit-bot: I haz the power, 2016-05-12 20:45:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 20:45:29]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-05-12 21:44:30]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-12 21:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1958453002/#ps120001
(title: "msw review")

[commit-bot: I haz the power, 2016-05-12 21:44:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958453002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958453002/120001

[commit-bot: I haz the power, 2016-05-12 21:52:02]

Description was changed from

==========
Update some secondary UI buttons to MD style.

This has no effect when --secondary-ui-md is not passed.

BUG=571500
==========

to

==========
Update some secondary UI buttons to MD style.

This has no effect when --secondary-ui-md is not passed.

BUG=571500
==========

[commit-bot: I haz the power, 2016-05-12 21:52:03]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-12 21:52:57]

Description was changed from

==========
Update some secondary UI buttons to MD style.

This has no effect when --secondary-ui-md is not passed.

BUG=571500
==========

to

==========
Update some secondary UI buttons to MD style.

This has no effect when --secondary-ui-md is not passed.

BUG=571500

Committed: https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077
Cr-Commit-Position: refs/heads/master@{#393368}
==========

[commit-bot: I haz the power, 2016-05-12 21:52:59]

Patchset 7 (id:??) landed as
https://crrev.com/a7bec092422dc5dd11afbecbe720b71df03de077
Cr-Commit-Position: refs/heads/master@{#393368}