Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1958433002: Do not fail when an enum constant is annotated (issue 26413) (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not fail when an enum constant is annotated (issue 26413) R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/451547ba27e943116776a0375de8c3157a62e9c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/constant/utilities.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-05 19:37:35 UTC) #2
jwren
On 2016/05/05 19:37:35, Brian Wilkerson wrote: LGTM
4 years, 7 months ago (2016-05-05 19:58:42 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-05-05 20:31:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
451547ba27e943116776a0375de8c3157a62e9c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698