Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1958413003: Assert that continuations be either LayoutBlockFlow or LayoutInline. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assert that continuations be either LayoutBlockFlow or LayoutInline. Exploring the possibility of moving all continuation handling from LayoutBlock down to LayoutBlockFlow. BUG=302024 Committed: https://crrev.com/fe93e2ba1dcc4ceadad76378697216d1c649422e Cr-Commit-Position: refs/heads/master@{#392621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 10:49:17 UTC) #2
eae
LGTM Sounds like a good plan.
4 years, 7 months ago (2016-05-10 15:32:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958413003/1
4 years, 7 months ago (2016-05-10 15:32:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 16:14:49 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 16:16:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe93e2ba1dcc4ceadad76378697216d1c649422e
Cr-Commit-Position: refs/heads/master@{#392621}

Powered by Google App Engine
This is Rietveld 408576698