Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1958393002: Reset BluetoothHostPairingController in an earlier stage for normal user login flow. (Closed)

Created:
4 years, 7 months ago by xdai1
Modified:
4 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset BluetoothHostPairingController in an earlier stage for normal user login flow. In normal user login flow, the Reset of BluetoothHostPairingController always happens when the controller deletes itself, which makes PowerOffAdapterIfApplicable() not guaranteed to be called. In order to prevent that, we reset the controller in an earlier stage. BUG=chrome-os-partner:52828 Committed: https://crrev.com/0532863ace38dac68940ee426576b46cb0baa548 Cr-Commit-Position: refs/heads/master@{#392763}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.h View 2 chunks +1 line, -1 line 0 comments Download
M components/pairing/fake_host_pairing_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/pairing/fake_host_pairing_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/pairing/host_pairing_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/pairing/shark_connection_listener.h View 1 chunk +2 lines, -0 lines 2 comments Download
M components/pairing/shark_connection_listener.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
xdai1
achuith@, could you help review this CL please? Thanks!
4 years, 7 months ago (2016-05-10 04:24:55 UTC) #2
xdai1
On 2016/05/10 04:24:55, xdai1 wrote: > achuith@, could you help review this CL please? Thanks! ...
4 years, 7 months ago (2016-05-10 18:44:10 UTC) #3
achuithb
lgtm Looking forward to the tests. https://codereview.chromium.org/1958393002/diff/20001/components/pairing/shark_connection_listener.h File components/pairing/shark_connection_listener.h (right): https://codereview.chromium.org/1958393002/diff/20001/components/pairing/shark_connection_listener.h#newcode34 components/pairing/shark_connection_listener.h:34: void ResetHostPairingController(); ResetController ...
4 years, 7 months ago (2016-05-10 22:05:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958393002/20001
4 years, 7 months ago (2016-05-10 22:05:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 23:07:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958393002/20001
4 years, 7 months ago (2016-05-10 23:10:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 23:15:37 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0532863ace38dac68940ee426576b46cb0baa548 Cr-Commit-Position: refs/heads/master@{#392763}
4 years, 7 months ago (2016-05-10 23:18:29 UTC) #13
achuithb
https://codereview.chromium.org/1958393002/diff/20001/components/pairing/shark_connection_listener.h File components/pairing/shark_connection_listener.h (right): https://codereview.chromium.org/1958393002/diff/20001/components/pairing/shark_connection_listener.h#newcode34 components/pairing/shark_connection_listener.h:34: void ResetHostPairingController(); On 2016/05/10 22:05:19, achuithb wrote: > ResetController ...
4 years, 7 months ago (2016-05-10 23:44:16 UTC) #14
xdai1
4 years, 7 months ago (2016-05-10 23:46:42 UTC) #15
Message was sent while issue was closed.
On 2016/05/10 23:44:16, achuithb wrote:
>
https://codereview.chromium.org/1958393002/diff/20001/components/pairing/shar...
> File components/pairing/shark_connection_listener.h (right):
> 
>
https://codereview.chromium.org/1958393002/diff/20001/components/pairing/shar...
> components/pairing/shark_connection_listener.h:34: void
> ResetHostPairingController();
> On 2016/05/10 22:05:19, achuithb wrote:
> > ResetController is sufficient I think.
> 
> ping?

Ahh sorry! I missed this comment... only saw lgtm :( 
Will address it in another CL in a couple minutes.

Powered by Google App Engine
This is Rietveld 408576698