Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1958363002: IntersectionObserver: check for constructed Frame. (Closed)

Created:
4 years, 7 months ago by szager1
Modified:
4 years, 7 months ago
Reviewers:
skobes, eae
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: check for constructed Frame. BUG=609712 R=eae@chromium.org,skobes@chromium.org Committed: https://crrev.com/26d82fa7cdf1004bcc890a8506763ff850452b9f Cr-Commit-Position: refs/heads/master@{#392687}

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : Fixed intrinsic width for overflow:auto, added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -181 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/flexbox/flexbox-height-with-overflow-auto.html View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/flexbox/scrollbars-auto.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/css3/flexbox/scrollbars-auto-expected.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 3 chunks +2 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 2 4 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 2 6 chunks +73 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 14 chunks +186 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/web/resources/listPicker.js View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
szager1
4 years, 7 months ago (2016-05-10 00:51:09 UTC) #1
skobes
test?
4 years, 7 months ago (2016-05-10 01:39:42 UTC) #2
szager1
On 2016/05/10 01:39:42, skobes wrote: > test? Done.
4 years, 7 months ago (2016-05-10 05:40:18 UTC) #3
skobes
lgtm
4 years, 7 months ago (2016-05-10 17:45:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958363002/20001
4 years, 7 months ago (2016-05-10 17:46:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 19:44:27 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:45:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26d82fa7cdf1004bcc890a8506763ff850452b9f
Cr-Commit-Position: refs/heads/master@{#392687}

Powered by Google App Engine
This is Rietveld 408576698