Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1958333004: Move font-variant-ligatures test to Mozilla style test (Closed)

Created:
4 years, 7 months ago by drott
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move font-variant-ligatures test to Mozilla style test For font-variant-caps we already ported the Mozilla style reftests. Let's do this for font-variant-ligatures as well. BUG=610662 R=eae,kojii Committed: https://crrev.com/875c983ebd0c65061aa7a0689193f8e9bf200460 Cr-Commit-Position: refs/heads/master@{#392771}

Patch Set 1 #

Patch Set 2 : Old expectations removed #

Patch Set 3 : Add reftest expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -157 lines) Patch
A + third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-ligatures.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/fast/text/font-features/font-variant-ligatures-expected.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/font-features/resources/font-variant-features.js View 1 chunk +27 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/text/font-variant-ligatures.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/font-variant-ligatures-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/text/font-variant-ligatures-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/font-variant-ligatures-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/font-variant-ligatures-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/text/font-variant-ligatures-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/font-variant-ligatures-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/text/font-variant-ligatures-expected.txt View 1 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
drott
4 years, 7 months ago (2016-05-10 11:57:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958333004/1
4 years, 7 months ago (2016-05-10 11:58:08 UTC) #4
drott
Old expectations removed
4 years, 7 months ago (2016-05-10 12:11:25 UTC) #5
drott
4 years, 7 months ago (2016-05-10 12:11:42 UTC) #6
drott
Add reftest expectations
4 years, 7 months ago (2016-05-10 14:34:13 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958333004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958333004/40001
4 years, 7 months ago (2016-05-10 14:34:21 UTC) #9
eae
LGTM
4 years, 7 months ago (2016-05-10 15:46:03 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/218969)
4 years, 7 months ago (2016-05-10 16:54:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958333004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958333004/40001
4 years, 7 months ago (2016-05-10 22:17:45 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 23:35:09 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 23:36:48 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/875c983ebd0c65061aa7a0689193f8e9bf200460
Cr-Commit-Position: refs/heads/master@{#392771}

Powered by Google App Engine
This is Rietveld 408576698