Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1958293002: Revert "Desktop Capture Picker New UI: Non Mac Structure Change" (Closed)

Created:
4 years, 7 months ago by stanisc
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Desktop Capture Picker New UI: Non Mac Structure Change" This reverts commit ec8a48393ac2f10940f3b6e63d1319222e660cff. Reason for the revert: Breaks a number of DesktopMediaPickerControllerTest tests on Builder: Mac10.9 Tests (dbg) (stats). https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 TBR=isherman@chromium.org,rockot@chromium.org,qiangchenC@chromium.org BUG=602478, 610016 Committed: https://chromium.googlesource.com/chromium/src/+/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2486 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 3 chunks +10 lines, -11 lines 0 comments Download
D chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h View 1 chunk +0 lines, -215 lines 0 comments Download
D chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc View 1 chunk +0 lines, -740 lines 0 comments Download
D chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc View 1 chunk +0 lines, -314 lines 0 comments Download
A + chrome/browser/ui/views/desktop_media_picker_views.h View 3 chunks +3 lines, -9 lines 0 comments Download
A + chrome/browser/ui/views/desktop_media_picker_views.cc View 8 chunks +21 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/desktop_media_picker_views_deprecated.h View 1 chunk +0 lines, -210 lines 0 comments Download
D chrome/browser/ui/views/desktop_media_picker_views_deprecated.cc View 1 chunk +0 lines, -670 lines 0 comments Download
D chrome/browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc View 1 chunk +0 lines, -231 lines 0 comments Download
A + chrome/browser/ui/views/desktop_media_picker_views_unittest.cc View 11 chunks +30 lines, -30 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623 Cr-Commit-Position: refs/heads/master@{#392451}
4 years, 7 months ago (2016-05-09 22:41:26 UTC) #2
stanisc
4 years, 7 months ago (2016-05-09 22:44:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
31c2d5a8cbeced5cb648ed5fea9a9e92efb13623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698