Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1958263003: Add the tabstrip height to the page calculation for peeking card so the card peeks for tablet (Closed)

Created:
4 years, 7 months ago by mcwilliams
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer, May
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the tabstrip height to the page calculation for peeking card so the card peeks for tablet BUG=610671 Committed: https://crrev.com/35826115ac6096ce6d7ce479d966166106d0b01f Cr-Commit-Position: refs/heads/master@{#392589}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mcwilliams
4 years, 7 months ago (2016-05-10 12:36:26 UTC) #2
Bernhard Bauer
+May
4 years, 7 months ago (2016-05-10 12:41:10 UTC) #4
May
lgtm
4 years, 7 months ago (2016-05-10 12:52:50 UTC) #5
Bernhard Bauer
lgtm https://codereview.chromium.org/1958263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java (right): https://codereview.chromium.org/1958263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java#newcode103 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java:103: int peekingCardHeight = getContext().getResources().getDimensionPixelSize( Nit: Remove the getContext()?
4 years, 7 months ago (2016-05-10 12:55:55 UTC) #6
mcwilliams
https://codereview.chromium.org/1958263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java (right): https://codereview.chromium.org/1958263003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java#newcode103 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java:103: int peekingCardHeight = getContext().getResources().getDimensionPixelSize( On 2016/05/10 12:55:55, Bernhard Bauer ...
4 years, 7 months ago (2016-05-10 13:05:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958263003/40001
4 years, 7 months ago (2016-05-10 13:05:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 13:45:13 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 13:46:10 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/35826115ac6096ce6d7ce479d966166106d0b01f
Cr-Commit-Position: refs/heads/master@{#392589}

Powered by Google App Engine
This is Rietveld 408576698