Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Issue 1958253004: Revert of [build] Use -O2 on linux by default (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [build] Use -O2 on linux by default (patchset #1 id:1 of https://codereview.chromium.org/1963693004/ ) Reason for revert: Causes regressions. Original issue's description: > [build] Use -O2 on linux by default > > This switches O2 -> O3 to match chromium's configuration. > > This makes the difference between gn and gyp a bit smaller > before switching. > > BUG=chromium:474921 > LOG=n > > Committed: https://crrev.com/a37ab71e343b8cc24df05868b941a49e0c271376 > Cr-Commit-Position: refs/heads/master@{#36124} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/413d9e2f4135219dd8ffa82d743ed9302dbc0ca0 Cr-Commit-Position: refs/heads/master@{#36135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M gypfiles/toolchain.gypi View 2 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [build] Use -O2 on linux by default
4 years, 7 months ago (2016-05-10 12:07:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958253004/1
4 years, 7 months ago (2016-05-10 12:08:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 12:08:19 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 12:10:00 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/413d9e2f4135219dd8ffa82d743ed9302dbc0ca0
Cr-Commit-Position: refs/heads/master@{#36135}

Powered by Google App Engine
This is Rietveld 408576698