Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 195823006: Revert 169264 "Add plumbing for font-stretch" (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews
Visibility:
Public.

Description

Revert 169264 "Add plumbing for font-stretch" Cause the below tests to crash on Linux Debug: fast/dom/shadow/pseudoclass-update-checked-option.html,fast/dom/shadow/pseudoclass-update-disabled-option.html,fast/dom/shadow/pseudoclass-update-enabled-option.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20%28dbg%29/builds/1058 > Add plumbing for font-stretch > > Implement support for parsing and querying the font-stretch CSS > property, for extracting the font-stretch from the short-hand font > property, and for querying the font-stretch through getComputedStyle. > > Note that this patch does _not_ implement the font-stretch > functionality itself, it merely adds the required plumbing. > > Request to implement thread: > https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/N24I2zJemvI > > Entry in Chromium Dashboard: > http://www.chromestatus.com/features/4598830058176512 > > R=dglazkov@chromium.org > BUG=331119 > TEST=fast/css3-text/font-stretch.html > > Review URL: https://codereview.chromium.org/199423003 TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -478 lines) Patch
M trunk/LayoutTests/fast/css/font-shorthand-expected.txt View 9 chunks +0 lines, -9 lines 0 comments Download
MM trunk/LayoutTests/fast/css/font-shorthand-from-longhands.html View 2 chunks +9 lines, -9 lines 0 comments Download
MM trunk/LayoutTests/fast/css/font-shorthand-from-longhands-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
MM trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt View 1 chunk +56 lines, -56 lines 0 comments Download
M trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
MM trunk/LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js View 1 chunk +56 lines, -56 lines 0 comments Download
D trunk/LayoutTests/fast/css3-text/font-stretch.html View 1 chunk +0 lines, -80 lines 0 comments Download
D trunk/LayoutTests/fast/css3-text/font-stretch-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M trunk/LayoutTests/fast/inspector-support/style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/CSSComputedStyleDeclaration.cpp View 5 chunks +1 line, -30 lines 0 comments Download
M trunk/Source/core/css/CSSFontValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/css/CSSFontValue.cpp View 3 chunks +1 line, -7 lines 0 comments Download
M trunk/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -70 lines 0 comments Download
M trunk/Source/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/css/CSSPropertyNames.in View 2 chunks +1 line, -1 line 0 comments Download
M trunk/Source/core/css/CSSShorthands.in View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/FontFaceSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/css/StylePropertySerializer.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/css/parser/CSSPropertyParser.cpp View 6 chunks +4 lines, -25 lines 0 comments Download
M trunk/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +0 lines, -23 lines 0 comments Download
M trunk/Source/core/css/resolver/FontBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/css/resolver/FontBuilder.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleBuilderCustom.cpp View 3 chunks +1 line, -53 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/Source/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
6 years, 9 months ago (2014-03-14 20:25:46 UTC) #1
Zhenyao Mo
6 years, 9 months ago (2014-03-14 20:27:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r169273.

Powered by Google App Engine
This is Rietveld 408576698