Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1958213002: Fix rendering of Runic on Windows (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
szager1
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix rendering of Runic on Windows Fix font fallback logic for Runic by removing USCRIPT_RUNIC from the win specific symbol and emoji font selection logic, instead using the script map to determine the appropriate Runic fonts based on the unicode block. BUG=607528 R=szager@chromium.org Committed: https://crrev.com/aca021a3bd4f6f479d5449ea4cd6e1b295b08d8f Cr-Commit-Position: refs/heads/master@{#392495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
4 years, 7 months ago (2016-05-09 18:52:23 UTC) #1
szager1
lgtm
4 years, 7 months ago (2016-05-09 20:48:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958213002/1
4 years, 7 months ago (2016-05-09 21:10:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 00:40:57 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 00:42:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aca021a3bd4f6f479d5449ea4cd6e1b295b08d8f
Cr-Commit-Position: refs/heads/master@{#392495}

Powered by Google App Engine
This is Rietveld 408576698