Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1958153004: [debugger] Prevent shared function info duplicates (Closed)

Created:
4 years, 7 months ago by jgruber1
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Prevent shared function info duplicates Clear the list of shared function infos attached to a script before compiling for live edit in order to avoid duplicates. This was lost in 058deb27132c97c62a99826455abc2bc87fae1b7. R=yangguo@chromium.org BUG= Committed: https://crrev.com/592432977e6213364c243c396060c7b64687ddc3 Cr-Commit-Position: refs/heads/master@{#36155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jgruber1
4 years, 7 months ago (2016-05-10 14:55:30 UTC) #1
Yang
On 2016/05/10 14:55:30, jgruber wrote: lgtm.
4 years, 7 months ago (2016-05-10 15:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958153004/1
4 years, 7 months ago (2016-05-11 06:45:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 07:15:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/592432977e6213364c243c396060c7b64687ddc3 Cr-Commit-Position: refs/heads/master@{#36155}
4 years, 7 months ago (2016-05-11 07:16:44 UTC) #7
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1973433002/ by machenbach@chromium.org. ...
4 years, 7 months ago (2016-05-11 10:14:42 UTC) #8
Michael Achenbach
4 years, 7 months ago (2016-05-11 10:15:47 UTC) #9
Message was sent while issue was closed.
This is the other suspect:
https://chromium.googlesource.com/v8/v8/+/0cb89c2677ac6668f5d5c03c72ac2decd61...

Powered by Google App Engine
This is Rietveld 408576698