Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 1958143002: Fix return-type for error-handlers in streams. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream_impl.dart
diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart
index dffaa1205910b222ea7ca6bbdbf197069f33cccd..0334c8ce8297eb3a8d42725625fa4472d5bf1caa 100644
--- a/sdk/lib/async/stream_impl.dart
+++ b/sdk/lib/async/stream_impl.dart
@@ -145,7 +145,7 @@ class _BufferingStreamSubscription<T> implements StreamSubscription<T>,
void onError(Function handleError) {
if (handleError == null) handleError = _nullErrorHandler;
- _onError = _registerErrorHandler/*<T>*/(handleError, _zone);
+ _onError = _registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
Lasse Reichstein Nielsen 2016/05/09 15:43:03 I need documentation for this comment. It's mean
floitsch 2016/05/09 16:53:55 You mean, there is too much comment? Do you prefer
Lasse Reichstein Nielsen 2016/05/09 18:56:10 I just don't know what it means. I have learned th
floitsch 2016/05/09 20:59:19 The /*void*/ is just a comment. It means that I wo
Lasse Reichstein Nielsen 2016/05/10 05:31:46 I think so, yes. It's confusing to have a comment
floitsch 2016/05/10 18:29:49 Done.
}
void onDone(void handleDone()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698