Fix return-type for error-handlers in streams.

Fix return-type for error-handlers in streams.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/5612898e2360411f714210225d47c1aabd3568cd

[Lasse Reichstein Nielsen, 2016-05-09 15:43:02]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2016-05-09 15:43:03]

LGTM if it fixes the bug.

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.dart
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.d...
sdk/lib/async/stream_impl.dart:148: _onError =
_registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
I need documentation for this comment. 

It's meaningful, so it should be treated as code, and it's not at all readable
(to me, at least).

[floitsch, 2016-05-09 16:53:55]

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.dart
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.d...
sdk/lib/async/stream_impl.dart:148: _onError =
_registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
On 2016/05/09 15:43:03, Lasse Reichstein Nielsen wrote:
> I need documentation for this comment. 
> 
> It's meaningful, so it should be treated as code, and it's not at all readable
> (to me, at least).

You mean, there is too much comment?
Do you prefer a comment stating that "dynamic" should be "void" ?

[Lasse Reichstein Nielsen, 2016-05-09 18:56:10]

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.dart
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.d...
sdk/lib/async/stream_impl.dart:148: _onError =
_registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
I just don't know what it means.
I have learned that /*<dynamic>*/ is a temporary place-holder for <dynamic> and
it's really strong-mode *code*, not documentation, but is the /*void*/ inside it
meaningful too? Or is it only documentation? And if so, what does it mean (it's
not obvious)?

[floitsch, 2016-05-09 20:59:19]

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.dart
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.d...
sdk/lib/async/stream_impl.dart:148: _onError =
_registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
On 2016/05/09 18:56:10, Lasse Reichstein Nielsen wrote:
> I just don't know what it means.
> I have learned that /*<dynamic>*/ is a temporary place-holder for <dynamic>
and
> it's really strong-mode *code*, not documentation, but is the /*void*/ inside
it
> meaningful too? Or is it only documentation? And if so, what does it mean
(it's
> not obvious)?

The /*void*/ is just a comment. It means that I would like to put "void" here,
but can't and therefore use 'dynamic' instead.

Should I just remove the '/*void*/' ?

[Lasse Reichstein Nielsen, 2016-05-10 05:31:46]

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.dart
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.d...
sdk/lib/async/stream_impl.dart:148: _onError =
_registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
I think so, yes. It's confusing to have a comment as part of another comment.
If you want to remind yourself that you want to write void (in case we make void
a first-class type), do that in a separate comment.

[floitsch, 2016-05-10 18:29:49]

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.dart
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/1958143002/diff/1/sdk/lib/async/stream_impl.d...
sdk/lib/async/stream_impl.dart:148: _onError =
_registerErrorHandler/*<dynamic/*void*/>*/(handleError, _zone);
On 2016/05/10 05:31:46, Lasse Reichstein Nielsen wrote:
> I think so, yes. It's confusing to have a comment as part of another comment.
> If you want to remind yourself that you want to write void (in case we make
void
> a first-class type), do that in a separate comment.

Done.

[floitsch, 2016-05-11 12:27:21]

Description was changed from

==========
Fix return-type for error-handlers in streams.
==========

to

==========
Fix return-type for error-handlers in streams.

R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5612898e2360411f714210225d47c1aabd3568cd
==========

[floitsch, 2016-05-11 12:27:22]

Committed patchset #2 (id:20001) manually as
5612898e2360411f714210225d47c1aabd3568cd (presubmit successful).