Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1958133002: [libfuzzer] Adding ASan Debug build configuration. (Closed)

Created:
4 years, 7 months ago by mmoroz
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] Adding ASan Debug build configuration. R=aizatsky@chromium.org, dpranke@chromium.org, ochang@chromium.org BUG=607627 Committed: https://crrev.com/ddbb47c14321d71cfc60d6a6684ae5db4b558ffc Cr-Commit-Position: refs/heads/master@{#392634}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Specified 'debug' explicitly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mmoroz
4 years, 7 months ago (2016-05-09 14:50:07 UTC) #1
Oliver Chang
https://codereview.chromium.org/1958133002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1958133002/diff/1/tools/mb/mb_config.pyl#newcode1094 tools/mb/mb_config.pyl:1094: 'disable_nacl', is_debug=true should be the default, but should we ...
4 years, 7 months ago (2016-05-09 16:50:00 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1958133002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1958133002/diff/1/tools/mb/mb_config.pyl#newcode1094 tools/mb/mb_config.pyl:1094: 'disable_nacl', On 2016/05/09 16:50:00, Oliver Chang wrote: > ...
4 years, 7 months ago (2016-05-09 18:42:23 UTC) #3
mmoroz
https://codereview.chromium.org/1958133002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1958133002/diff/1/tools/mb/mb_config.pyl#newcode1094 tools/mb/mb_config.pyl:1094: 'disable_nacl', On 2016/05/09 18:42:23, Dirk Pranke wrote: > On ...
4 years, 7 months ago (2016-05-10 08:47:30 UTC) #4
Oliver Chang
lgtm
4 years, 7 months ago (2016-05-10 15:51:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958133002/20001
4 years, 7 months ago (2016-05-10 15:57:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 17:16:46 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:18:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddbb47c14321d71cfc60d6a6684ae5db4b558ffc
Cr-Commit-Position: refs/heads/master@{#392634}

Powered by Google App Engine
This is Rietveld 408576698