Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1908)

Unified Diff: Source/devtools/front_end/TimelineUIUtils.js

Issue 195813010: DevTools: avoid using stale front-end node ids. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/LayerTreeModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/TimelineUIUtils.js b/Source/devtools/front_end/TimelineUIUtils.js
index bfb70bc195afaa40b97e2911350e38dd23375cea..76356bdaf359d7ad7c944ca2e858a0b5a011ee61 100644
--- a/Source/devtools/front_end/TimelineUIUtils.js
+++ b/Source/devtools/front_end/TimelineUIUtils.js
@@ -444,13 +444,13 @@ WebInspector.TimelineUIUtils.createStyleRuleForCategory = function(category)
WebInspector.TimelineUIUtils.generatePopupContent = function(record, linkifier, callback)
{
var imageElement = /** @type {?Element} */ (record.getUserObject("TimelineUIUtils::preview-element") || null);
- var relatedNode = /** @type {?WebInspector.DOMNode} */ (record.getUserObject("TimelineUIUtils::related-node") || null);
+ var relatedNode = null;
var barrier = new CallbackBarrier();
if (!imageElement && WebInspector.TimelineUIUtils.needsPreviewElement(record.type))
WebInspector.DOMPresentationUtils.buildImagePreviewContents(record.url, false, barrier.createCallback(saveImage));
- if (!relatedNode && record.relatedBackendNodeId())
- WebInspector.domAgent.pushNodesByBackendIdsToFrontend([record.relatedBackendNodeId()], barrier.createCallback(saveNode));
+ if (record.relatedBackendNodeId())
+ WebInspector.domAgent.pushNodesByBackendIdsToFrontend([record.relatedBackendNodeId()], barrier.createCallback(setRelatedNode));
barrier.callWhenDone(callbackWrapper);
/**
@@ -465,12 +465,10 @@ WebInspector.TimelineUIUtils.generatePopupContent = function(record, linkifier,
/**
* @param {?Array.<!DOMAgent.NodeId>} nodeIds
*/
- function saveNode(nodeIds)
+ function setRelatedNode(nodeIds)
{
- if (nodeIds !== null) {
+ if (nodeIds)
relatedNode = WebInspector.domAgent.nodeForId(nodeIds[0]);
- record.setUserObject("TimelineUIUtils::related-node", relatedNode);
- }
}
function callbackWrapper()
« no previous file with comments | « Source/devtools/front_end/LayerTreeModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698