Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: Source/devtools/front_end/LayerTreeModel.js

Issue 195813010: DevTools: avoid using stale front-end node ids. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/LayerTreeModel.js
diff --git a/Source/devtools/front_end/LayerTreeModel.js b/Source/devtools/front_end/LayerTreeModel.js
index 2f553d23bcecd67eea17eb810f2f8facc17ac69f..b71c491b5b7946544ebf6166ce6328c82bd260b2 100644
--- a/Source/devtools/front_end/LayerTreeModel.js
+++ b/Source/devtools/front_end/LayerTreeModel.js
@@ -201,8 +201,10 @@ WebInspector.LayerTreeModel.prototype = {
var requestedIds = [];
for (var i = 0; i < layers.length; ++i) {
var backendNodeId = layers[i].backendNodeId;
- if (!backendNodeId || this._backendNodeIdToNodeId[backendNodeId] || idsToResolve[backendNodeId])
+ if (!backendNodeId || idsToResolve[backendNodeId] ||
+ (this._backendNodeIdToNodeId[backendNodeId] && WebInspector.domAgent.nodeForId(this._backendNodeIdToNodeId[backendNodeId]))) {
continue;
+ }
idsToResolve[backendNodeId] = true;
requestedIds.push(backendNodeId);
}
« no previous file with comments | « LayoutTests/inspector/layers/layer-tree-model-expected.txt ('k') | Source/devtools/front_end/TimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698