Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 195813010: DevTools: avoid using stale front-end node ids. (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 9 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: avoid using stale front-end node ids. When a node is removed and then re-added to the document, the back-end node id remains the same and the front-end id is new. This means that if we keep resolved front-end nodes, we should check if these still exist and re-resolve the ids to new nodes if these are detached and re-attached to the document. BUG= R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169526

Patch Set 1 : #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -46 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/layers-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/layers/layer-tree-model.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/layers/layer-tree-model-expected.txt View 1 chunk +35 lines, -35 lines 0 comments Download
M Source/devtools/front_end/LayerTreeModel.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/TimelineUIUtils.js View 1 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vsevik
lgtm
6 years, 9 months ago (2014-03-14 10:03:26 UTC) #1
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-14 13:32:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/195813010/20001
6 years, 9 months ago (2014-03-14 13:32:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 14:00:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-14 14:00:43 UTC) #5
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-18 16:03:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/195813010/40001
6 years, 9 months ago (2014-03-18 16:04:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 16:05:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-18 16:05:44 UTC) #9
caseq
6 years, 9 months ago (2014-03-19 07:53:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r169526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698