Source/core/html/HTMLSummaryElement.cpp - Issue 195813003: Use new is*Element() helper functions further more in HTML code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSummaryElement.cpp

Issue 195813003: Use new is*Element() helper functions further more in HTML code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix bad assertion Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLSummaryElement.cpp

diff --git a/Source/core/html/HTMLSummaryElement.cpp b/Source/core/html/HTMLSummaryElement.cpp

index 43fa4110859d923a2f10723bda1351f2ea92fc36..d213a27e37f118e11c3e93ba3c7f04b4053a69c5 100644

--- a/Source/core/html/HTMLSummaryElement.cpp

+++ b/Source/core/html/HTMLSummaryElement.cpp

@@ -61,7 +61,7 @@ void HTMLSummaryElement::didAddUserAgentShadowRoot(ShadowRoot& root)

HTMLDetailsElement* HTMLSummaryElement::detailsElement() const

{

Node* parent = NodeRenderingTraversal::parent(this);

- if (parent && parent->hasTagName(detailsTag))

+ if (isHTMLDetailsElement(parent))

return toHTMLDetailsElement(parent);

return 0;

}