Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: Source/core/html/HTMLTableElement.cpp

Issue 195813003: Use new is*Element() helper functions further more in HTML code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix bad assertion Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 19 matching lines...) Expand all
30 #include "HTMLNames.h" 30 #include "HTMLNames.h"
31 #include "bindings/v8/ExceptionState.h" 31 #include "bindings/v8/ExceptionState.h"
32 #include "bindings/v8/ExceptionStatePlaceholder.h" 32 #include "bindings/v8/ExceptionStatePlaceholder.h"
33 #include "core/css/CSSImageValue.h" 33 #include "core/css/CSSImageValue.h"
34 #include "core/css/CSSValuePool.h" 34 #include "core/css/CSSValuePool.h"
35 #include "core/css/StylePropertySet.h" 35 #include "core/css/StylePropertySet.h"
36 #include "core/dom/Attribute.h" 36 #include "core/dom/Attribute.h"
37 #include "core/dom/ElementTraversal.h" 37 #include "core/dom/ElementTraversal.h"
38 #include "core/dom/ExceptionCode.h" 38 #include "core/dom/ExceptionCode.h"
39 #include "core/html/HTMLTableCaptionElement.h" 39 #include "core/html/HTMLTableCaptionElement.h"
40 #include "core/html/HTMLTableCellElement.h"
40 #include "core/html/HTMLTableRowElement.h" 41 #include "core/html/HTMLTableRowElement.h"
41 #include "core/html/HTMLTableRowsCollection.h" 42 #include "core/html/HTMLTableRowsCollection.h"
42 #include "core/html/HTMLTableSectionElement.h" 43 #include "core/html/HTMLTableSectionElement.h"
43 #include "core/html/parser/HTMLParserIdioms.h" 44 #include "core/html/parser/HTMLParserIdioms.h"
44 #include "core/rendering/RenderTable.h" 45 #include "core/rendering/RenderTable.h"
45 #include "wtf/StdLibExtras.h" 46 #include "wtf/StdLibExtras.h"
46 47
47 namespace WebCore { 48 namespace WebCore {
48 49
49 using namespace HTMLNames; 50 using namespace HTMLNames;
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 return; 249 return;
249 } 250 }
250 row->remove(exceptionState); 251 row->remove(exceptionState);
251 } 252 }
252 253
253 void HTMLTableElement::setNeedsTableStyleRecalc() const 254 void HTMLTableElement::setNeedsTableStyleRecalc() const
254 { 255 {
255 Element* element = ElementTraversal::next(*this, this); 256 Element* element = ElementTraversal::next(*this, this);
256 while (element) { 257 while (element) {
257 element->setNeedsStyleRecalc(LocalStyleChange); 258 element->setNeedsStyleRecalc(LocalStyleChange);
258 if (element->hasTagName(tdTag) || element->hasTagName(thTag)) 259 if (isHTMLTableCellElement(*element))
259 element = ElementTraversal::nextSkippingChildren(*element, this); 260 element = ElementTraversal::nextSkippingChildren(*element, this);
260 else 261 else
261 element = ElementTraversal::next(*element, this); 262 element = ElementTraversal::next(*element, this);
262 } 263 }
263 } 264 }
264 265
265 static bool getBordersFromFrameAttributeValue(const AtomicString& value, bool& b orderTop, bool& borderRight, bool& borderBottom, bool& borderLeft) 266 static bool getBordersFromFrameAttributeValue(const AtomicString& value, bool& b orderTop, bool& borderRight, bool& borderBottom, bool& borderLeft)
266 { 267 {
267 borderTop = false; 268 borderTop = false;
268 borderRight = false; 269 borderRight = false;
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 { 550 {
550 return getAttribute(rulesAttr); 551 return getAttribute(rulesAttr);
551 } 552 }
552 553
553 const AtomicString& HTMLTableElement::summary() const 554 const AtomicString& HTMLTableElement::summary() const
554 { 555 {
555 return getAttribute(summaryAttr); 556 return getAttribute(summaryAttr);
556 } 557 }
557 558
558 } 559 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698