third_party/WebKit/Source/core/editing/VisibleSelection.cpp - Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2017-01-16T20:04:35 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.h ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

index c2dac8421a0b8aeb429250c91966d3afb40fa4b8..354b8ad17df63e0a8d05f84d2bc450501ab1c457 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

@@ -480,7 +480,8 @@ void VisibleSelectionTemplate<Strategy>::validate(TextGranularity granularity) {

// TODO(xiaochengh): Add a DocumentLifecycle::DisallowTransitionScope here.

m_granularity = granularity;

- m_hasTrailingWhitespace = false;

+ if (m_granularity != WordGranularity)

+ m_hasTrailingWhitespace = false;

setBaseAndExtentToDeepEquivalents();

if (m_base.isNull() || m_extent.isNull()) {

m_base = m_extent = m_start = m_end = PositionTemplate<Strategy>();

@@ -516,6 +517,9 @@ void VisibleSelectionTemplate<Strategy>::validate(TextGranularity granularity) {

m_start = mostForwardCaretPosition(m_start);

m_end = mostBackwardCaretPosition(m_end);

}

+ if (!m_hasTrailingWhitespace)

+ return;

+ appendTrailingWhitespace();

}

template <typename Strategy>