Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: third_party/WebKit/Source/core/editing/PendingSelection.cpp

Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2017-01-16T20:04:35 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PendingSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/PendingSelection.cpp b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
index da2ae734d4a63734c3ea40430f1ee0d54ef9e463..0d53fb1383c590f28157217bba87a1e8183a97e2 100644
--- a/third_party/WebKit/Source/core/editing/PendingSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
@@ -110,10 +110,13 @@ void PendingSelection::commit(LayoutView& layoutView) {
if (!hasPendingSelection())
return;
DCHECK(!layoutView.needsLayout());
+ // We should check have |DCHECK(!document().m_needsLayout()); but,
+ // media/track/track-model.html and others don't satisfied.
+ // m_frameSelection->document().assertLayoutTreeIsUpToDate();
m_hasPendingSelection = false;
const VisibleSelectionInFlatTree& originalSelection =
- m_frameSelection->visibleSelection<EditingInFlatTreeStrategy>();
+ m_frameSelection->computeVisibleSelectionInFlatTree();
// Skip if pending VisibilePositions became invalid before we reach here.
if (!isSelectionInDocument(originalSelection, layoutView.document()))
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp ('k') | third_party/WebKit/Source/core/editing/Position.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698