third_party/WebKit/Source/core/editing/DragCaretController.cpp - Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DragCaretController.cpp

Issue 1958093002: CONTINUED Make FrameSelection to hold non-canonicalized positions Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2017-01-16T20:04:35 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/DragCaretController.h ('k') | third_party/WebKit/Source/core/editing/FrameCaret.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/DragCaretController.cpp

diff --git a/third_party/WebKit/Source/core/editing/DragCaretController.cpp b/third_party/WebKit/Source/core/editing/DragCaretController.cpp

index 61f97229792aa4a98eaf1cf099db83375786edba..0ea817ca90ad3efcd4fff33d4df25c0cfa5652be 100644

--- a/third_party/WebKit/Source/core/editing/DragCaretController.cpp

+++ b/third_party/WebKit/Source/core/editing/DragCaretController.cpp

@@ -104,7 +104,6 @@ void DragCaretController::nodeWillBeRemoved(Node& node) {

DEFINE_TRACE(DragCaretController) {

visitor->trace(m_position);

- visitor->trace(m_caretBase);

SynchronousMutationObserver::trace(visitor);

}

@@ -112,9 +111,8 @@ void DragCaretController::paintDragCaret(LocalFrame* frame,

GraphicsContext& context,

const LayoutPoint& paintOffset) const {

if (m_position.anchorNode()->document().frame() == frame) {

- CaretBase::paintCaret(m_position.anchorNode(), context, *m_caretBase,

- m_caretLocalRect, paintOffset,

- DisplayItem::kDragCaret);

+ m_caretBase->paintCaret(m_position.anchorNode(), context, m_caretLocalRect,

+ paintOffset, DisplayItem::kDragCaret);

}