Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to METER element.

Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element if
  - it is in User-Agent ShadowRoot, and
  - its shadow host has -webkit-appearance value other than "none".
This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

This CL has no user-visible behavior changes.

BUG=609669
Committed: https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15
Cr-Commit-Position: refs/heads/master@{#393779}

[tkent, 2016-05-09 09:21:32]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance selector, and apply it to METER
element.

BUG=
==========

to

==========
Introduce :-internal-shadow-host-has-appearance selector, and apply it to METER
element.

BUG=609669
==========

[tkent, 2016-05-09 13:53:07]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance selector, and apply it to METER
element.

BUG=609669
==========

to

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

BUG=609669
==========

[tkent, 2016-05-09 13:54:28]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

BUG=609669
==========

to

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

Also, this CL adds "::-webkit-internal-fallback" pseudo element.
TODO(tkent): Should we introduce

BUG=609669
==========

[tkent, 2016-05-09 13:55:41]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

Also, this CL adds "::-webkit-internal-fallback" pseudo element.
TODO(tkent): Should we introduce

BUG=609669
==========

to

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

Also, this CL adds "::-webkit-internal-fallback" pseudo element.
TODO(tkent): Should we introduce PseudoBlinkInternalElement instead of using
PseudoWebKitCustomElement?

BUG=609669
==========

[tkent, 2016-05-09 15:55:29]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

Also, this CL adds "::-webkit-internal-fallback" pseudo element.
TODO(tkent): Should we introduce PseudoBlinkInternalElement instead of using
PseudoWebKitCustomElement?

BUG=609669
==========

to

==========
THIS CL IS NOT READY TO BE COMMITTED.

Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

Also, this CL adds "::-webkit-internal-fallback" pseudo element.
TODO(tkent): Should we introduce PseudoBlinkInternalElement instead of using
PseudoWebKitCustomElement?

BUG=609669
==========

[esprehn, 2016-05-09 19:39:49]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-05-09 19:39:50]

I do think this is much better. Yeah it's crazy, but at least it's way less
code.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:921: if (!m_isUARule)
this should check that containingShadowRoot()->type() is a UserAgentShadowRoot.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:925: if
(!element.shadowHost()->computedStyle())
Don't call computedStyle repeatedly, save to a local and null check that.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:972: if
(selector.value().startsWith("-webkit-internal-") && !m_isUARule)
why do we need this? We should just make the pseudo only apply inside a UA
shadow.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Element.h (right):

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Element.h:454: // with "-webkit-internal-",
selectors including the pseudo ID is usable
just -internal, not -webkit-internal. We don't add more -webkits. :)

[tkent, 2016-05-10 04:23:52]

Description was changed from

==========
THIS CL IS NOT READY TO BE COMMITTED.

Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

Also, this CL adds "::-webkit-internal-fallback" pseudo element.
TODO(tkent): Should we introduce PseudoBlinkInternalElement instead of using
PseudoWebKitCustomElement?

BUG=609669
==========

to

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element
in
User-Agent ShadowRoot and its shadow host has -webkit-appearance value other
than
"none".  This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

BUG=609669
==========

[tkent, 2016-05-10 04:26:37]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element
in
User-Agent ShadowRoot and its shadow host has -webkit-appearance value other
than
"none".  This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

BUG=609669
==========

to

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element
if
  - it is in User-Agent ShadowRoot, and
  - its shadow host has -webkit-appearance value other than "none".
This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

This CL has no user-visible behavior changes.

BUG=609669
==========

[tkent, 2016-05-10 04:29:30]

Patch Set 2 is ready for review.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:921: if (!m_isUARule)
On 2016/05/09 at 19:39:50, esprehn wrote:
> this should check that containingShadowRoot()->type() is a
UserAgentShadowRoot.

Done.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:925: if
(!element.shadowHost()->computedStyle())
On 2016/05/09 at 19:39:50, esprehn wrote:
> Don't call computedStyle repeatedly, save to a local and null check that.

Done.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:972: if
(selector.value().startsWith("-webkit-internal-") && !m_isUARule)
On 2016/05/09 at 19:39:50, esprehn wrote:
> why do we need this? We should just make the pseudo only apply inside a UA
shadow.

We should avoid to expose new vendor-specific pseudo elements.

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Element.h (right):

https://codereview.chromium.org/1958073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Element.h:454: // with "-webkit-internal-",
selectors including the pseudo ID is usable
On 2016/05/09 at 19:39:50, esprehn wrote:
> just -internal, not -webkit-internal. We don't add more -webkits. :)

Done.
PseudoWebKitCustomElement needs to start with "-webkit-".  New patch introduces
PseudoBlinkInternalElement, starting with "-internal-".

[esprehn, 2016-05-13 22:18:40]

lgtm

https://codereview.chromium.org/1958073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/1958073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:924: if (root->type() !=
ShadowRootType::UserAgent || !root->host())
host() can't be null on a ShadowRoot

[esprehn, 2016-05-13 22:18:48]

On 2016/05/13 at 22:18:40, esprehn wrote:
> lgtm
> 
>
https://codereview.chromium.org/1958073002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):
> 
>
https://codereview.chromium.org/1958073002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/SelectorChecker.cpp:924: if (root->type()
!= ShadowRootType::UserAgent || !root->host())
> host() can't be null on a ShadowRoot

lgtm w/ the null check removed.

[tkent, 2016-05-16 00:21:25]

https://codereview.chromium.org/1958073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/SelectorChecker.cpp (right):

https://codereview.chromium.org/1958073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/SelectorChecker.cpp:924: if (root->type() !=
ShadowRootType::UserAgent || !root->host())
On 2016/05/13 at 22:18:40, esprehn wrote:
> host() can't be null on a ShadowRoot

Removed the null check.

[tkent, 2016-05-16 00:21:28]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-05-16 00:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1958073002/#ps40001
(title: "Remove null host check")

[commit-bot: I haz the power, 2016-05-16 00:21:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1958073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1958073002/40001

[commit-bot: I haz the power, 2016-05-16 01:07:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-16 01:08:52]

Description was changed from

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element
if
  - it is in User-Agent ShadowRoot, and
  - its shadow host has -webkit-appearance value other than "none".
This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

This CL has no user-visible behavior changes.

BUG=609669
==========

to

==========
Introduce :-internal-shadow-host-has-appearance pseudo class, and apply it to
METER element.

:-internal-shadow-host-has-appearance pseudo class matches to a shadow element
if
  - it is in User-Agent ShadowRoot, and
  - its shadow host has -webkit-appearance value other than "none".
This class is available only in UA stylesheets.

Also, this CL adds PseudoBlinkInternalElement.  It's similar to
PseudoWebKitCustomElement.  Their differences are:
 - Pseudo ID of PseudoBlinkInternalElement starts with "-internal-".
 - ::-internal-* selectors are available only in UA stylesheets.

METER's fallback element uses PseudoBlinkInternalElement in order to avoid to
expose new vendor-specific elements.

This CL has no user-visible behavior changes.

BUG=609669

Committed: https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15
Cr-Commit-Position: refs/heads/master@{#393779}
==========

[commit-bot: I haz the power, 2016-05-16 01:08:53]

Patchset 3 (id:??) landed as
https://crrev.com/19b50f20c2da2f0f3efddd91e3df57ba4a4e8b15
Cr-Commit-Position: refs/heads/master@{#393779}