Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1958063002: Clean up this/holder usage in accessors.cc (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up this/holder usage in accessors.cc BUG= Committed: https://crrev.com/4cad4c054eee7c8c9e73d32d7d72b3e43230b1c8 Cr-Commit-Position: refs/heads/master@{#36104}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M src/accessors.cc View 18 chunks +23 lines, -20 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-05-09 08:53:44 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1958063002/diff/1/src/accessors.cc File src/accessors.cc (right): https://codereview.chromium.org/1958063002/diff/1/src/accessors.cc#newcode162 src/accessors.cc:162: Handle<Object> receiver = Utils::OpenHandle(*info.This()); since this is set through ...
4 years, 7 months ago (2016-05-09 08:56:26 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-09 08:59:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958063002/1
4 years, 7 months ago (2016-05-09 11:11:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 11:38:16 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 11:40:10 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4cad4c054eee7c8c9e73d32d7d72b3e43230b1c8
Cr-Commit-Position: refs/heads/master@{#36104}

Powered by Google App Engine
This is Rietveld 408576698