Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1958043002: Don't crash when load eval origin of a call site. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't crash when load eval origin of a call site. BUG=chromium:610207 LOG=N Committed: https://crrev.com/8758245a62c152bc23dcbb8cdc6ceac9693b52f0 Cr-Commit-Position: refs/heads/master@{#36101}

Patch Set 1 #

Patch Set 2 : fixing regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M src/accessors.cc View 1 chunk +10 lines, -8 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-610207.js View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958043002/1
4 years, 7 months ago (2016-05-09 08:18:30 UTC) #2
Igor Sheludko
PTAL
4 years, 7 months ago (2016-05-09 08:18:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958043002/20001
4 years, 7 months ago (2016-05-09 08:28:20 UTC) #6
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-05-09 08:44:11 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-09 08:55:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1958043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1958043002/20001
4 years, 7 months ago (2016-05-09 08:56:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 09:00:09 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 09:00:57 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8758245a62c152bc23dcbb8cdc6ceac9693b52f0
Cr-Commit-Position: refs/heads/master@{#36101}

Powered by Google App Engine
This is Rietveld 408576698