Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: blimp/engine/BUILD.gn

Issue 1958033003: Allows client to access auth token from command line specified file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed kmarshall's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index 728f475c5bcaa7bb909f3ac1336ac45d55195447..bfc588a89d03f76eeeeadde3b405855606ca7ca8 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -60,7 +60,6 @@ source_set("app") {
":app_net",
":app_permissions",
":app_settings",
- ":app_switches",
":app_ui",
":blob_channel",
":common",
@@ -69,6 +68,7 @@ source_set("app") {
":session",
"//base",
"//blimp/common",
+ "//blimp/common:app_switches",
Kevin M 2016/05/11 00:39:57 Remove "app_switches" and just use "common" top-le
CJ 2016/05/11 23:48:49 Done.
"//blimp/common/proto",
"//blimp/engine:blob_channel_mojo_cpp_sources",
"//blimp/net",
@@ -89,8 +89,9 @@ source_set("app_config") {
"app/blimp_engine_config.h",
]
deps = [
- ":app_switches",
"//base",
+ "//blimp/common",
+ "//blimp/common:app_switches",
"//cc",
"//content/public/common",
"//ui/gl",
@@ -139,13 +140,6 @@ source_set("app_settings") {
]
}
-source_set("app_switches") {
- sources = [
- "app/switches.cc",
- "app/switches.h",
- ]
-}
-
source_set("app_ui") {
sources = [
"app/ui/blimp_layout_manager.cc",
@@ -281,12 +275,12 @@ source_set("session") {
deps = [
":app_config",
":app_settings",
- ":app_switches",
":app_ui",
":common",
":feature",
"//base",
"//blimp/common",
+ "//blimp/common:app_switches",
"//blimp/common/proto",
"//blimp/net",
"//content/public/browser",
@@ -342,10 +336,11 @@ source_set("app_unit_tests") {
":app",
":app_config",
":app_settings",
- ":app_switches",
"//base",
"//base/test:run_all_unittests",
"//base/test:test_support",
+ "//blimp/common:app_switches",
+ "//blimp/common:test_support",
"//blimp/engine:app_ui",
"//testing/gmock",
"//testing/gtest",

Powered by Google App Engine
This is Rietveld 408576698