blimp/common/switches.h - Issue 1958033003: Allows client to access auth token from command line specified file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/switches.h

Issue 1958033003: Allows client to access auth token from command line specified file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed kmarshall's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	Kevin M 2016/05/11 00:39:57 2016 2016 CJ 2016/05/11 23:48:49 Done. Show quoted text On 2016/05/11 00:39:57, Kevin M wrote: > 2016 Done.
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BLIMP_ENGINE_APP_SWITCHES_H_	5 #ifndef BLIMP_COMMON_SWITCHES_H_

6 #define BLIMP_ENGINE_APP_SWITCHES_H_	6 #define BLIMP_COMMON_SWITCHES_H_

7	7

8 namespace blimp {	8 namespace blimp {

9 namespace engine {	9 namespace engine {
	Kevin M 2016/05/11 00:39:57 The "engine" namespace doesn't belong here. The "engine" namespace doesn't belong here. CJ 2016/05/11 23:48:49 Done. Show quoted text On 2016/05/11 00:39:57, Kevin M wrote: > The "engine" namespace doesn't belong here. Done.
10	10

11 // Path to the client token/shared secret between the engine and the client.	11 // Path to the client token/shared secret between the engine and the client.

12 extern const char kClientTokenPath[];	12 extern const char kClientTokenPath[];

13	13

14 // The port to listen to for incoming TCP connections.	14 // The port to listen to for incoming TCP connections.
	Kevin M 2016/05/11 00:39:57 A listen port is engine-specific, so it shouldn't A listen port is engine-specific, so it shouldn't be under common/. CJ 2016/05/11 23:48:49 Done. Show quoted text On 2016/05/11 00:39:57, Kevin M wrote: > A listen port is engine-specific, so it shouldn't be under common/. Done.
15 extern const char kEnginePort[];	15 extern const char kEnginePort[];

16	16

17 } // namespace engine	17 } // namespace engine

18 } // namespace blimp	18 } // namespace blimp

19	19

20 #endif // BLIMP_ENGINE_APP_SWITCHES_H_	20 #endif // BLIMP_COMMON_SWITCHES_H_

OLD	NEW

« blimp/common/BUILD.gn ('K') | « blimp/common/get_client_token.cc ('k') | blimp/common/switches.cc » ('j') | blimp/common/switches.cc » ('J')