Allows client to access auth token from command line specified file.

blimp/common/fake_commandline.h

+// Copyright 2016 The Chromium Authors. All rights reserved.

[Kevin M, 2016/05/10 18:06:35]

We should use the token testdata file, so this helper library won't be
necessary.

I realize a lot of this is refactored from the engine config test, but I'll go
ahead and comment on issues I've seen in this file for educational purposes. No
need to address actually them if you are rm'ing this file.

[CJ, 2016/05/10 20:58:06]

So, I should make the server test look more like the client tests, and have them
both take in blimp/test/data/test_client_token?

[Kevin M, 2016/05/11 00:39:56]

Yeah.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_COMMON_FAKE_COMMANDLINE_H_
+#define BLIMP_COMMON_FAKE_COMMANDLINE_H_
+
+#include <string>
+#include <vector>
+
+#include "base/command_line.h"
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
+#include "blimp/engine/app/switches.h"
+
+namespace blimp {
+
+// Creates a file in the temp directory for a given filepath switch.
+void CreateFileForSwitch(const std::string& filepath_switch,

[Kevin M, 2016/05/10 18:06:34]

We don't need to create a tmpfile (or have any supporting functions for it) if
we just use blimp/test/data/test_client_token .

+                         const std::string& data);
+
+// Removes the associated file for a given filepath switch.
+void RemoveFileForSwitch(const std::string& filepath_switch);
+
+// Creates and returns a CommandLine object with specified filepath switches.
+base::CommandLine CreateCommandLine(

[Kevin M, 2016/05/10 18:06:35]

This isn't necessary; look at the existing unit tests to see how they manipulate
the current command line.

+    const std::vector<std::string>& filepath_switches);
+
+base::FilePath GetFilepathForSwitch(const std::string& filepath_switch);
+
+const std::vector<std::string> all_filepath_switches_ =

[Kevin M, 2016/05/10 18:06:35]

1. Non-POD (Plain Old Data) constants are disallowed.
2. Please refer to the style guide for constant naming conventions. In this
case, we use kConstant.

+{engine::kClientTokenPath};

[Kevin M, 2016/05/10 18:06:34]

Brace initialization, while cool, isn't allowed yet. Chromium must be
compileable on a wide range of compilers, and compatibility for this mode of
initialization isn't verified to be at 100% just yet.

See https://chromium-cpp.appspot.com/ , "Uniform Initialization Syntax".

This isn't being caught by the compiler because this target is compiled by Linux
builders only, but if this happened to be built by MSVC, the buildbot would fail
the CL.

+
+base::ScopedTempDir temp_dir_;
+}  // namespace blimp
+
+#endif  // BLIMP_COMMON_FAKE_COMMANDLINE_H_