third_party/flatbuffers/BUILD.gn - Issue 1958033002: Remove include_test*.fbs from build files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/flatbuffers/BUILD.gn

Issue 1958033002: Remove include_test*.fbs from build files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Balazs' comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/flatbuffers/BUILD.gn

diff --git a/third_party/flatbuffers/BUILD.gn b/third_party/flatbuffers/BUILD.gn

index 3897cfa982d996549c30b129be2c733c31872a87..cc5b2d8367dce1e6d75286e303b3ea8e5a6fcfc2 100644

--- a/third_party/flatbuffers/BUILD.gn

+++ b/third_party/flatbuffers/BUILD.gn

@@ -57,8 +57,9 @@ executable("flatc") {

flatbuffer("flatbuffers_samplebuffer") {

testonly = true

sources = [

- "src/tests/include_test1.fbs",

- "src/tests/include_test2.fbs",

+ # Disabled as workaround for crbug.com/611351

+ # "src/tests/include_test1.fbs",

+ # "src/tests/include_test2.fbs",

"src/tests/monster_test.fbs",

"src/tests/namespace_test/namespace_test1.fbs",

"src/tests/namespace_test/namespace_test2.fbs",

« no previous file with comments | « no previous file | third_party/flatbuffers/flatbuffers.gyp » ('j') | no next file with comments »