Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2138)

Unified Diff: chrome/browser/metrics/extensions_metrics_provider_unittest.cc

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/extensions_metrics_provider_unittest.cc
diff --git a/chrome/browser/metrics/extensions_metrics_provider_unittest.cc b/chrome/browser/metrics/extensions_metrics_provider_unittest.cc
index 934e2bffc2a04a10d1ed29744b33b0e46ebf021a..16ec748bb395005b8e01fc3bc66c010e053ffce5 100644
--- a/chrome/browser/metrics/extensions_metrics_provider_unittest.cc
+++ b/chrome/browser/metrics/extensions_metrics_provider_unittest.cc
@@ -13,6 +13,7 @@
#include "components/metrics/metrics_service.h"
#include "components/metrics/metrics_state_manager.h"
#include "components/metrics/proto/system_profile.pb.h"
+#include "components/metrics/test_enabled_state_provider.h"
#include "components/prefs/testing_pref_service.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
@@ -21,10 +22,6 @@
namespace {
-bool IsMetricsReportingEnabled() {
- return true;
-}
-
void StoreNoClientInfoBackup(const metrics::ClientInfo& /* client_info */) {
}
@@ -108,10 +105,11 @@ TEST(ExtensionsMetricsProvider, HashExtension) {
TEST(ExtensionsMetricsProvider, SystemProtoEncoding) {
metrics::SystemProfileProto system_profile;
TestingPrefServiceSimple local_state;
+ metrics::TestEnabledStateProvider enabled_state_provider(true, true);
metrics::MetricsService::RegisterPrefs(local_state.registry());
std::unique_ptr<metrics::MetricsStateManager> metrics_state_manager(
metrics::MetricsStateManager::Create(
- &local_state, base::Bind(&IsMetricsReportingEnabled),
+ &local_state, &enabled_state_provider,
base::Bind(&StoreNoClientInfoBackup), base::Bind(&ReturnNoBackup)));
TestExtensionsMetricsProvider extension_metrics(metrics_state_manager.get());
extension_metrics.ProvideSystemProfileMetrics(&system_profile);

Powered by Google App Engine
This is Rietveld 408576698