Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Unified Diff: blimp/engine/app/blimp_metrics_service_client.cc

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/app/blimp_metrics_service_client.cc
diff --git a/blimp/engine/app/blimp_metrics_service_client.cc b/blimp/engine/app/blimp_metrics_service_client.cc
index 20db13dee244073695d7bdd7c555ffa2578a627e..060ff9e32097d91b706279914f45d8aa9f13e337 100644
--- a/blimp/engine/app/blimp_metrics_service_client.cc
+++ b/blimp/engine/app/blimp_metrics_service_client.cc
@@ -31,13 +31,6 @@ namespace {
// metrics service.
const int kStandardUploadIntervalMinutes = 30;
-// Returns if the MetricsService should be recording metrics information for
-// the client. Always true.
-// This callback is required by MetricsStateManager::Create.
-bool IsReportingEnabled() {
- return true;
-}
-
// Store/LoadClientInfo allows Windows Chrome to back up ClientInfo.
// Both are no-ops for Blimp.
// These callbacks are required by MetricsStateManager::Create.
@@ -55,8 +48,8 @@ BlimpMetricsServiceClient::BlimpMetricsServiceClient(
request_context_getter_ = request_context_getter;
metrics_state_manager_ = metrics::MetricsStateManager::Create(
- pref_service, base::Bind(&IsReportingEnabled),
- base::Bind(&StoreClientInfo), base::Bind(&LoadClientInfo));
+ pref_service, this, base::Bind(&StoreClientInfo),
+ base::Bind(&LoadClientInfo));
// Metrics state manager created while other class instances exist.
// Sign of multiple initializations.
@@ -163,5 +156,9 @@ BlimpMetricsServiceClient::GetDefaultOptIn() {
return OPT_IN;
}
+bool BlimpMetricsServiceClient::IsConsentGiven() {
+ return true;
+}
+
} // namespace engine
} // namespace blimp
« no previous file with comments | « blimp/engine/app/blimp_metrics_service_client.h ('k') | chrome/browser/metrics/chrome_metrics_services_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698