Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_metrics_service_client.cc
diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc
index 685cc33f88eb67db7ba1c6913ee35923be88ce7f..3129fe9df65064f791f6c049afb13289da49c0c8 100644
--- a/android_webview/browser/aw_metrics_service_client.cc
+++ b/android_webview/browser/aw_metrics_service_client.cc
@@ -10,6 +10,7 @@
#include "base/guid.h"
#include "base/i18n/rtl.h"
#include "components/metrics/call_stack_profile_metrics_provider.h"
+#include "components/metrics/enabled_state_provider.h"
#include "components/metrics/gpu/gpu_metrics_provider.h"
#include "components/metrics/metrics_pref_names.h"
#include "components/metrics/metrics_service.h"
@@ -98,9 +99,8 @@ void AwMetricsServiceClient::InitializeWithGUID(std::string* guid) {
pref_service_->SetString(metrics::prefs::kMetricsClientID, *guid);
metrics_state_manager_ = metrics::MetricsStateManager::Create(
- pref_service_, base::Bind(&AwMetricsServiceClient::is_reporting_enabled,
- base::Unretained(this)),
- base::Bind(&StoreClientInfo), base::Bind(&LoadClientInfo));
+ pref_service_, this, base::Bind(&StoreClientInfo),
+ base::Bind(&LoadClientInfo));
metrics_service_.reset(new ::metrics::MetricsService(
metrics_state_manager_.get(), this, pref_service_));
@@ -130,7 +130,7 @@ void AwMetricsServiceClient::InitializeWithGUID(std::string* guid) {
is_initialized_ = true;
- if (is_reporting_enabled())
+ if (IsReportingEnabled())
metrics_service_->Start();
}
@@ -148,6 +148,11 @@ void AwMetricsServiceClient::SetMetricsEnabled(bool enabled) {
is_enabled_ = enabled;
}
+bool AwMetricsServiceClient::IsConsentGiven() {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+ return is_enabled_;
+}
+
metrics::MetricsService* AwMetricsServiceClient::GetMetricsService() {
return metrics_service_.get();
}
@@ -222,9 +227,4 @@ AwMetricsServiceClient::AwMetricsServiceClient()
AwMetricsServiceClient::~AwMetricsServiceClient() {}
-bool AwMetricsServiceClient::is_reporting_enabled() {
- DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- return is_enabled_;
-}
-
} // namespace android_webview
« no previous file with comments | « android_webview/browser/aw_metrics_service_client.h ('k') | blimp/engine/app/blimp_metrics_service_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698