Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2460)

Unified Diff: blimp/engine/app/blimp_metrics_service_client.h

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing and updating blimp_metrics_service_client Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/app/blimp_metrics_service_client.h
diff --git a/blimp/engine/app/blimp_metrics_service_client.h b/blimp/engine/app/blimp_metrics_service_client.h
index 192b568cc0c0b91182402862b68ac6cff0c3ebf5..3c2a8c723bad02fa81b6ce2de3cfe9636abb0109 100644
--- a/blimp/engine/app/blimp_metrics_service_client.h
+++ b/blimp/engine/app/blimp_metrics_service_client.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "components/metrics/enabled_state_provider.h"
#include "components/metrics/metrics_service_client.h"
class PrefService;
@@ -32,7 +33,8 @@ namespace engine {
// tailored for the Blimp engine to support the upload of metrics information
// from the engine.
// Metrics are always turned on.
-class BlimpMetricsServiceClient : public metrics::MetricsServiceClient {
+class BlimpMetricsServiceClient : public metrics::MetricsServiceClient,
+ public metrics::EnabledStateProvider {
public:
// PrefService ownership is retained by the caller.
// The request_context_getter is a system request context.
@@ -62,6 +64,11 @@ class BlimpMetricsServiceClient : public metrics::MetricsServiceClient {
metrics::MetricsServiceClient::EnableMetricsDefault GetDefaultOptIn()
override;
+ // metrics::EnabledStateProvider:
Kevin M 2016/05/12 17:58:46 nit: "metrics::EnabledStateProvider implementation
jwd 2016/05/12 18:09:45 Done.
+ // Returns if consent is given for the MetricsService to record metrics
+ // information for the client. Always true.
+ bool IsConsentGiven() override;
+
private:
// Used by NetMetricsLogUploader to create log-upload requests.
scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
« no previous file with comments | « android_webview/browser/aw_metrics_service_client.cc ('k') | blimp/engine/app/blimp_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698