Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3335)

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/metrics/cast_metrics_service_client.cc
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc
index a6041cb60dcfa336a2651845a596cea994c165b7..4bfd3df7b83b8975f8b5e4e3b95f12b4b849732c 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.cc
+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc
@@ -22,6 +22,7 @@
#include "chromecast/browser/metrics/cast_stability_metrics_provider.h"
#include "chromecast/public/cast_sys_info.h"
#include "components/metrics/client_info.h"
+#include "components/metrics/enabled_state_provider.h"
#include "components/metrics/gpu/gpu_metrics_provider.h"
#include "components/metrics/metrics_provider.h"
#include "components/metrics/metrics_service.h"
@@ -260,6 +261,10 @@ base::TimeDelta CastMetricsServiceClient::GetStandardUploadInterval() {
return base::TimeDelta::FromMinutes(kStandardUploadIntervalMinutes);
}
+bool CastMetricsServiceClient::IsConsentGiven() {
+ return pref_service_->GetBoolean(prefs::kOptInStats);
+}
+
void CastMetricsServiceClient::EnableMetricsService(bool enabled) {
if (!task_runner_->BelongsToCurrentThread()) {
task_runner_->PostTask(
@@ -326,9 +331,7 @@ void CastMetricsServiceClient::Initialize(CastService* cast_service) {
cast_service_ = cast_service;
metrics_state_manager_ = ::metrics::MetricsStateManager::Create(
- pref_service_,
- base::Bind(&CastMetricsServiceClient::IsReportingEnabled,
- base::Unretained(this)),
+ pref_service_, this,
base::Bind(&CastMetricsServiceClient::StoreClientInfo,
base::Unretained(this)),
base::Bind(&CastMetricsServiceClient::LoadClientInfo,
@@ -410,9 +413,5 @@ void CastMetricsServiceClient::Finalize() {
metrics_service_->Stop();
}
-bool CastMetricsServiceClient::IsReportingEnabled() {
- return pref_service_->GetBoolean(prefs::kOptInStats);
-}
-
} // namespace metrics
} // namespace chromecast

Powered by Google App Engine
This is Rietveld 408576698