Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3500)

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/metrics/cast_metrics_service_client.h
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h
index af88142c7f8be187ec02187a54f7417dbb705afa..73a536ecbede1ece341463e01324bbd3424b91c9 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.h
+++ b/chromecast/browser/metrics/cast_metrics_service_client.h
@@ -25,6 +25,7 @@ class TaskRunner;
namespace metrics {
struct ClientInfo;
+class EnabledStateProvider;
class MetricsService;
class MetricsStateManager;
} // namespace metrics
@@ -88,6 +89,8 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
std::string client_id() const { return client_id_; }
private:
+ class CastEnabledStateProvider;
Alexei Svitkine (slow) 2016/05/11 17:16:28 Nit: Same comment as for Aw client - just make it
jwd 2016/05/11 18:31:38 Done.
+
CastMetricsServiceClient(base::TaskRunner* io_task_runner,
PrefService* pref_service,
net::URLRequestContextGetter* request_context);
@@ -112,6 +115,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {
const scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
std::unique_ptr<::metrics::MetricsStateManager> metrics_state_manager_;
std::unique_ptr<::metrics::MetricsService> metrics_service_;
+ std::unique_ptr<::metrics::EnabledStateProvider> enabled_state_provider_;
net::URLRequestContextGetter* const request_context_;
DISALLOW_COPY_AND_ASSIGN(CastMetricsServiceClient);

Powered by Google App Engine
This is Rietveld 408576698