Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_METRICS_IOS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_ 5 #ifndef IOS_CHROME_BROWSER_METRICS_IOS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_
6 #define IOS_CHROME_BROWSER_METRICS_IOS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_ 6 #define IOS_CHROME_BROWSER_METRICS_IOS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/threading/thread_checker.h" 11 #include "base/threading/thread_checker.h"
12 #include "components/metrics_services_manager/metrics_services_manager_client.h" 12 #include "components/metrics_services_manager/metrics_services_manager_client.h"
13 13
14 class PrefService; 14 class PrefService;
15 15
16 namespace metrics { 16 namespace metrics {
17 class EnabledStateProvider;
17 class MetricsStateManager; 18 class MetricsStateManager;
18 } 19 }
19 20
20 // Provides an //ios/chrome-specific implementation of 21 // Provides an //ios/chrome-specific implementation of
21 // MetricsServicesManagerClient. 22 // MetricsServicesManagerClient.
22 class IOSChromeMetricsServicesManagerClient 23 class IOSChromeMetricsServicesManagerClient
23 : public metrics_services_manager::MetricsServicesManagerClient { 24 : public metrics_services_manager::MetricsServicesManagerClient {
24 public: 25 public:
25 explicit IOSChromeMetricsServicesManagerClient(PrefService* local_state); 26 explicit IOSChromeMetricsServicesManagerClient(PrefService* local_state);
26 ~IOSChromeMetricsServicesManagerClient() override; 27 ~IOSChromeMetricsServicesManagerClient() override;
27 28
28 private: 29 private:
30 class IOSChromeEnabledStateProvider;
Alexei Svitkine (slow) 2016/05/11 18:37:26 Nit: Move to be an anon namespace class and remove
jwd 2016/05/11 19:17:04 Adding comment.
31
29 // metrics_services_manager::MetricsServicesManagerClient: 32 // metrics_services_manager::MetricsServicesManagerClient:
30 std::unique_ptr<rappor::RapporService> CreateRapporService() override; 33 std::unique_ptr<rappor::RapporService> CreateRapporService() override;
31 std::unique_ptr<variations::VariationsService> CreateVariationsService() 34 std::unique_ptr<variations::VariationsService> CreateVariationsService()
32 override; 35 override;
33 std::unique_ptr<metrics::MetricsServiceClient> CreateMetricsServiceClient() 36 std::unique_ptr<metrics::MetricsServiceClient> CreateMetricsServiceClient()
34 override; 37 override;
35 net::URLRequestContextGetter* GetURLRequestContext() override; 38 net::URLRequestContextGetter* GetURLRequestContext() override;
36 bool IsSafeBrowsingEnabled(const base::Closure& on_update_callback) override; 39 bool IsSafeBrowsingEnabled(const base::Closure& on_update_callback) override;
37 bool IsMetricsReportingEnabled() override; 40 bool IsMetricsReportingEnabled() override;
38 bool OnlyDoMetricsRecording() override; 41 bool OnlyDoMetricsRecording() override;
39 42
40 // Gets the MetricsStateManager, creating it if it has not already been 43 // Gets the MetricsStateManager, creating it if it has not already been
41 // created. 44 // created.
42 metrics::MetricsStateManager* GetMetricsStateManager(); 45 metrics::MetricsStateManager* GetMetricsStateManager();
43 46
44 // MetricsStateManager which is passed as a parameter to service constructors. 47 // MetricsStateManager which is passed as a parameter to service constructors.
45 std::unique_ptr<metrics::MetricsStateManager> metrics_state_manager_; 48 std::unique_ptr<metrics::MetricsStateManager> metrics_state_manager_;
46 49
50 // EnabledStateProvider to communicate if the client has consented to metrics
51 // reporting, and if it's enabled.
52 std::unique_ptr<metrics::EnabledStateProvider> enabled_state_provider_;
53
47 // Ensures that all functions are called from the same thread. 54 // Ensures that all functions are called from the same thread.
48 base::ThreadChecker thread_checker_; 55 base::ThreadChecker thread_checker_;
49 56
50 // Weak pointer to the local state prefs store. 57 // Weak pointer to the local state prefs store.
51 PrefService* local_state_; 58 PrefService* local_state_;
52 59
53 DISALLOW_COPY_AND_ASSIGN(IOSChromeMetricsServicesManagerClient); 60 DISALLOW_COPY_AND_ASSIGN(IOSChromeMetricsServicesManagerClient);
54 }; 61 };
55 62
56 #endif // IOS_CHROME_BROWSER_METRICS_IOS_CHROME_METRICS_SERVICES_MANAGER_CLIENT _H_ 63 #endif // IOS_CHROME_BROWSER_METRICS_IOS_CHROME_METRICS_SERVICES_MANAGER_CLIENT _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698