components/metrics/enabled_state_provider.h - Issue 1958003003: Splitting the concept of UMA consent, and should UMA report.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/enabled_state_provider.h

Issue 1958003003: Splitting the concept of UMA consent, and should UMA report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromecast/browser/metrics/cast_metrics_service_client.h ('K') | « components/metrics/BUILD.gn ('k') | components/metrics/enabled_state_provider.cc » ('j') | components/metrics/metrics_state_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_METRICS_ENABLED_STATE_PROVIDER_H_

	6 #define COMPONENTS_METRICS_ENABLED_STATE_PROVIDER_H_

	7

	8 namespace metrics {

	9

	10 // An interface that provides whether metrics should be reported.

	11 class EnabledStateProvider {

	12 public:

	13 virtual ~EnabledStateProvider() {}

	14

	15 // Indicates that the user has provided consent to collect and report metrics.

	16 virtual bool IsConsentGiven() = 0;

	17

	18 // Should collection and reporting be enabled. This should depend on consent

	19 // being given.
	Alexei Svitkine (slow) 2016/05/11 17:16:28 Nit: Please expand comment to shed light of why th Nit: Please expand comment to shed light of why this would be different. Suggest just mentioning sampling as an example and explaining. jwd 2016/05/11 18:31:38 Done. Show quoted text On 2016/05/11 17:16:28, Alexei Svitkine wrote: > Nit: Please expand comment to shed light of why this would be different. Suggest > just mentioning sampling as an example and explaining. Done.
	20 virtual bool IsReportingEnabled();

	21 };

	22

	23 } // namespace metrics

	24

	25 #endif // COMPONENTS_METRICS_ENABLED_STATE_PROVIDER_H_

OLD	NEW