Splitting the concept of UMA consent, and should UMA report.

components/metrics/metrics_state_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/metrics_state_manager.h"
 
 #include <ctype.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "components/metrics/client_info.h"
 #include "components/metrics/metrics_pref_names.h"
 #include "components/metrics/metrics_service.h"
 #include "components/metrics/metrics_switches.h"
+#include "components/metrics/test_enabled_state_provider.h"
 #include "components/prefs/testing_pref_service.h"
 #include "components/variations/caching_permuted_entropy_provider.h"
 #include "components/variations/pref_names.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace metrics {
 
 class MetricsStateManagerTest : public testing::Test {
  public:
-  MetricsStateManagerTest() : is_metrics_reporting_enabled_(false) {
+  MetricsStateManagerTest()
+      : enabled_state_provider_(new TestEnabledStateProvider(false, false)) {
     MetricsService::RegisterPrefs(prefs_.registry());
   }
 
   std::unique_ptr<MetricsStateManager> CreateStateManager() {
     return MetricsStateManager::Create(
-        &prefs_,
-        base::Bind(&MetricsStateManagerTest::is_metrics_reporting_enabled,
-                   base::Unretained(this)),
+        &prefs_, enabled_state_provider_.get(),
         base::Bind(&MetricsStateManagerTest::MockStoreClientInfoBackup,
                    base::Unretained(this)),
         base::Bind(&MetricsStateManagerTest::LoadFakeClientInfoBackup,
                    base::Unretained(this)));
   }
 
   // Sets metrics reporting as enabled for testing.
   void EnableMetricsReporting() {
-    is_metrics_reporting_enabled_ = true;
+    enabled_state_provider_->set_consent(true);
+    enabled_state_provider_->set_enabled(true);
   }
 
  protected:
   TestingPrefServiceSimple prefs_;
 
   // Last ClientInfo stored by the MetricsStateManager via
   // MockStoreClientInfoBackup.
   std::unique_ptr<ClientInfo> stored_client_info_backup_;
 
   // If set, will be returned via LoadFakeClientInfoBackup if requested by the
   // MetricsStateManager.
   std::unique_ptr<ClientInfo> fake_client_info_backup_;
 
  private:
-  bool is_metrics_reporting_enabled() const {
-    return is_metrics_reporting_enabled_;
-  }
-
   // Stores the |client_info| in |stored_client_info_backup_| for verification
   // by the tests later.
   void MockStoreClientInfoBackup(const ClientInfo& client_info) {
     stored_client_info_backup_.reset(new ClientInfo);
     stored_client_info_backup_->client_id = client_info.client_id;
     stored_client_info_backup_->installation_date =
         client_info.installation_date;
     stored_client_info_backup_->reporting_enabled_date =
         client_info.reporting_enabled_date;
 
@@ skipping 11 matching lines @@
 
     std::unique_ptr<ClientInfo> backup_copy(new ClientInfo);
     backup_copy->client_id = fake_client_info_backup_->client_id;
     backup_copy->installation_date =
         fake_client_info_backup_->installation_date;
     backup_copy->reporting_enabled_date =
         fake_client_info_backup_->reporting_enabled_date;
     return backup_copy;
   }
 
-  bool is_metrics_reporting_enabled_;
+  std::unique_ptr<TestEnabledStateProvider> enabled_state_provider_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsStateManagerTest);
 };
 
 // Ensure the ClientId is formatted as expected.
 TEST_F(MetricsStateManagerTest, ClientIdCorrectlyFormatted) {
   std::unique_ptr<MetricsStateManager> state_manager(CreateStateManager());
   state_manager->ForceClientIdCreation();
 
   const std::string client_id = state_manager->client_id();
@@ skipping 270 matching lines @@
 
     // The metrics-reporting-enabled date will be reset to Now().
     EXPECT_GE(prefs_.GetInt64(prefs::kMetricsReportingEnabledTimestamp),
               previous_client_info->reporting_enabled_date);
 
     stored_client_info_backup_.reset();
   }
 }
 
 }  // namespace metrics