Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1957973003: Preserve the selected shipping option index. (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@test-dismiss-cvc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preserve the selected shipping option index. When the user selects a shipping option, the merchant can update the list of line items and shipping options. If the merchant sends back unchanged shipping options, then this update should not clear user's shipping option selection. BUG=607705 Committed: https://crrev.com/1222c2859b500ee61b3070f4c39db4a77a16be77 Cr-Commit-Position: refs/heads/master@{#392816}

Patch Set 1 #

Patch Set 2 : Check for shipping option equality #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -33 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 18 chunks +58 lines, -33 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
please use gerrit instead
dfalcantara@, ptal.
4 years, 7 months ago (2016-05-09 01:11:37 UTC) #2
gone
Is it possible that the shipping options get rearranged? I imagine that the user could ...
4 years, 7 months ago (2016-05-09 16:59:38 UTC) #4
please use gerrit instead
On 2016/05/09 16:59:38, dfalcantara wrote: > Is it possible that the shipping options get rearranged? ...
4 years, 7 months ago (2016-05-09 17:02:40 UTC) #5
please use gerrit instead
dfalcantara@, ptal patch 2.
4 years, 7 months ago (2016-05-11 00:59:46 UTC) #6
gone
lgtm
4 years, 7 months ago (2016-05-11 01:08:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957973003/40001
4 years, 7 months ago (2016-05-11 01:14:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-11 01:51:57 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 01:53:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1222c2859b500ee61b3070f4c39db4a77a16be77
Cr-Commit-Position: refs/heads/master@{#392816}

Powered by Google App Engine
This is Rietveld 408576698