Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: service/datastore/raw_interface.go

Issue 1957953002: Add cloud datastore implementation. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Adjust minimum coverage. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/finalized_query.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/raw_interface.go
diff --git a/service/datastore/raw_interface.go b/service/datastore/raw_interface.go
index b9388037e9db3276dd3264a5886f1872d5d7cf4e..96e54d3370311ffb63b4a2e01065ab94d0a2bc80 100644
--- a/service/datastore/raw_interface.go
+++ b/service/datastore/raw_interface.go
@@ -140,9 +140,11 @@ type RawInterface interface {
// GetMulti retrieves items from the datastore.
//
- // Callback execues once per key, in the order of keys. Callback may not
- // execute at all if there's a server error. If callback is nil, this
- // method does nothing.
+ // If there was a server error, it will be returned directly. Otherwise,
+ // callback will execute once per key/value pair, returning either the
+ // operation result or individual error for each position. If the callback
+ // receives an error, it will immediately forward that error and stop
+ // subsequent callbacks.
//
// meta is used to propagate metadata from higher levels.
//
@@ -154,8 +156,11 @@ type RawInterface interface {
// PutMulti writes items to the datastore.
//
- // Callback execues once per key/value pair, in the passed-in order. Callback
- // may not execute at all if there was a server error.
+ // If there was a server error, it will be returned directly. Otherwise,
+ // callback will execute once per key/value pair, returning either the
+ // operation result or individual error for each position. If the callback
+ // receives an error, it will immediately forward that error and stop
+ // subsequent callbacks.
//
// NOTE: Implementations and filters are guaranteed that:
// - len(keys) > 0
@@ -166,8 +171,11 @@ type RawInterface interface {
// DeleteMulti removes items from the datastore.
//
- // Callback execues once per key, in the order of keys. Callback may not
- // execute at all if there's a server error.
+ // If there was a server error, it will be returned directly. Otherwise,
+ // callback will execute once per key/value pair, returning either the
+ // operation result or individual error for each position. If the callback
+ // receives an error, it will immediately forward that error and stop
+ // subsequent callbacks.
//
// NOTE: Implementations and filters are guaranteed that
// - len(keys) > 0
« no previous file with comments | « service/datastore/finalized_query.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698