Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 195793024: Move PersitentValueMap into seperate header, to avoid excessive polution (Closed)

Created:
6 years, 9 months ago by vogelheim
Modified:
6 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move PersitentValueMap into seperate header, to avoid excessive polution of v8.h. R=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19936

Patch Set 1 #

Patch Set 2 : First attempt at providing default traits for STL containers. #

Patch Set 3 : Seperated out two Traits classes, to make it easier to use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -222 lines) Patch
M include/v8.h View 1 2 7 chunks +8 lines, -181 lines 0 comments Download
A include/v8-util.h View 1 2 1 chunk +296 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 5 chunks +15 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vogelheim
6 years, 9 months ago (2014-03-14 14:52:56 UTC) #1
dcarney
lgtm
6 years, 9 months ago (2014-03-14 14:55:17 UTC) #2
dcarney
Committed patchset #1 manually as r19936 (presubmit successful).
6 years, 9 months ago (2014-03-14 14:57:11 UTC) #3
dcarney
6 years, 9 months ago (2014-03-14 19:26:21 UTC) #4
Message was sent while issue was closed.
can you move the new stuff into a new cl?  I committed the first patch of this
so that we would have the option of landing the blink patch on Monday.

Powered by Google App Engine
This is Rietveld 408576698