Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: git_cl.py

Issue 195793021: Infer CL author and reviewer list from local state if the issue has not previously been uploaded. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Add an additional test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 82d5a78abb6f5780fe0dafcca334cf03353e8a1a..1a1c64847f26c098dd292278249108de56e42980 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1694,6 +1694,11 @@ def CMDupload(parser, args):
cl.SetWatchers(watchlist.GetWatchersForPaths(files))
if not options.bypass_hooks:
+ if options.reviewers:
+ # Set the reviewer list now so that presubmit checks can access it.
+ change_description = ChangeDescription(change.FullDescriptionText())
+ change_description.update_reviewers(options.reviewers)
+ change.SetDescriptionText(change_description.description)
hook_results = cl.RunHook(committing=False,
may_prompt=not options.force,
verbose=options.verbose,
« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698