Infer CL author and reviewer list from local state if the issue has not previously been uploaded.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 834 matching lines @@
 
 
 def _GetRietveldIssueProps(input_api, messages):
   """Gets the issue properties from rietveld."""
   issue = input_api.change.issue
   if issue and input_api.rietveld:
     return input_api.rietveld.get_issue_properties(
         issue=int(issue), messages=messages)
 
 
+def _ReviewersFromChange(change):
+  """Return the reviewers specified in the |change|, if any."""
+  reviewers = set()
+  if change.R:
+    reviewers.update(set([r.strip() for r in change.R.split(',')]))
+  if change.TBR:
+    reviewers.update(set([r.strip() for r in change.TBR.split(',')]))
+  return reviewers
+
+
 def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):
   """Return the owner and reviewers of a change, if any.
 
   If approval_needed is True, only reviewers who have approved the change
   will be returned.
   """
   issue_props = _GetRietveldIssueProps(input_api, True)
   if not issue_props:
-    return None, set()
+    return None, _ReviewersFromChange(input_api.change)

[agable, 2014/03/14 15:11:03]

This doesn't coincide with the docstring, which says that reviewers will only be
returned if they've given approval when approval_needed==True.

[Ilya Sherman, 2014/03/18 01:18:35]

Good catch.  Fixed.

 
   if not approval_needed:
     return issue_props['owner_email'], set(issue_props['reviewers'])
 
   owner_email = issue_props['owner_email']
 
   def match_reviewer(r):
     return email_regexp.match(r) and r != owner_email
 
   messages = issue_props.get('messages', [])
@@ skipping 172 matching lines @@
 def CheckPatchFormatted(input_api, output_api):
   import git_cl
   cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]
   code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)
   if code == 2:
     return [output_api.PresubmitPromptWarning(
       'Your patch is not formatted, please run git cl format.')]
   # As this is just a warning, ignore all other errors if the user
   # happens to have a broken clang-format, doesn't use git, etc etc.
   return []